Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic config providers for IOConfig ConsumerProperties #19

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

vzayts
Copy link

@vzayts vzayts commented Feb 26, 2024

Add dynamic config providers for IOConfig ConsumerProperties to be used in Kafka ingestion spec for supervisor.

@vzayts vzayts added the area/core Core code related issue label Feb 26, 2024
@vzayts vzayts marked this pull request as ready for review February 27, 2024 03:21
Copy link
Collaborator

@zoido zoido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

common_spec_types.go Outdated Show resolved Hide resolved
Co-authored-by: Luboš Pokorný <[email protected]>
@vzayts vzayts merged commit 1bb0da8 into master Feb 27, 2024
3 checks passed
@vzayts vzayts deleted the vzaytsev/add-kafka-creds-to-consumer-properties branch February 27, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Core code related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants