Always include rollup field #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasz-h2o
force-pushed
the
tomasz/always-include-rollup
branch
2 times, most recently
from
8460489 to
61cb54f
Compare
tomasz-h2o
force-pushed
the
tomasz/always-include-rollup
branch
from
61cb54f to
dd3e4a6
Compare
tomasz-h2o
requested review from
vzayts,
zoido and
codyharris-h2o-ai
as code owners
zoido
approved these changes
Jan 15, 2024
Base automatically changed from
tomasz/options-to-submit-reindex-task
to
master
January 15, 2024 13:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where submitting a task with
rollup=falsewas not possible as bool field set tofalsewas treated as empty by json marshaller.