Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate sbmlmath testing #241

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Alternate sbmlmath testing #241

merged 5 commits into from
Sep 11, 2023

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Sep 11, 2023

No description provided.

Copy link
Contributor

@nanglo123 nanglo123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All unit tests for modeling api that involve the sbmlmath library are now passing instead of being ignored.

@nanglo123 nanglo123 marked this pull request as ready for review September 11, 2023 15:43
@cthoyt
Copy link
Member Author

cthoyt commented Sep 11, 2023

@nanglo123 do you want to clean up the rest of this PR by removing the pytest marks for SBMLmath? I think there's a second file that contains them, and we would no longer need the pytest configuration nor the flags in the github action

@nanglo123
Copy link
Contributor

@cthoyt Finished changing the decorators for the rest of the unit tests that require sbmlmath

@cthoyt cthoyt merged commit 987d6a1 into main Sep 11, 2023
4 checks passed
@cthoyt cthoyt deleted the sbmlmath-testing branch September 11, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants