-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending and testing the AMR-based modeling API #239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…relevant comment in ops.py
…g picking dict item objects in repplace observable id method
…te_id unit test to not check for length equality between old and new amr expressions asstates do not have to be a single letter
… currently pass for replace_initial_id
…tests for remove_transition and replace_rate_law_sympy
…or test_replace_rate_law_sympy to test both output amr expression and expression_mathml
…_expression(xml_str) rather than sympy.repr(str) to method
…ailure more apparent and fixed bug where changed parameter ids not showing in parameter list of new_amr
…eplacing observable id to accept a display name argument
…ccompanying unit test
…e objects have a non None value for their display name attribute
…s and parameters are not showing in the output amr) and its accompanying unit test
…ion and added decorator to all unit tests that require sbmlmath
…that require sbmlmath, forced pydantic<2.0 dependency for purpose of testing due to conflict with TestModelAPi
…n list of markers
…changed mira operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is redoing the PR #238 by @nanglo123 against the main branch.
New MIRA Operations in
mira/modeling/askenet/ops.py
replace_rate_law_mathml
add_parameter
remove_X
where X is an observable or parameteradd_transition
add_observable
replace_x_expression
Unit tests for MIRA operations in
tests/test_modeling/test_askenet.py
add_parameter
. Currently, the unit test foradd_transition
doesn't test for the presence of newly added states and parameters.Bug Fixes
Fixed a bug in commit
e9cb3dc
where changed parameters after callingreplace_parameter_id
were not showing in outputamr['semantics']['ode']['parameters']
Fixed a bug in commit
0ae9ed0
and commita1e6381
where observables in the output amr had identical values for theirname
andid
field (template model-> amr). Also fixed an issue where template models constructed from an amr file (amr -> template model) used aobservables['id']
for the name and display_name of a concept. Now thename
field will take the display_name attribute associated with a concept andid
will take the id attribute associated with a oncept.