-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new release artifact for jakarta.servlet support #9845
Merged
niloc132
merged 37 commits into
gwtproject:main
from
niloc132:9727-jakarta-servlet-support
Dec 6, 2023
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
aa27cbc
Add Jakarta servlet support, only for gwt-servlet
niloc132 cf522ad
Suggested dependency cleanup
niloc132 40fb94c
Merge remote-tracking branch 'github/main' into 9727-jakarta-servlet-…
niloc132 21156bc
Add Jakarta servlet support, only for gwt-servlet
niloc132 d41c753
Suggested dependency cleanup
niloc132 1dcd329
gwtproject/gwt#9727 : generate source jar for servlet jakarta
sparsick a589c6a
gwtproject/gwt#9727 : generate javadoc jar for servlet jakarta
sparsick b5b659f
gwtproject/gwt#9727 : move jakarata specific classes and their depend…
sparsick caf36fe
gwtproject/gwt#9727: adjust javadoc generation to match all jakarta r…
sparsick 53652ba
gwtproject/gwt#9727: add encoding information
sparsick 62cb80f
gwtproject/gwt#9727: fix CI build
sparsick 10c9e92
gwtproject/gwt#9727: adjust tools ref for testing
sparsick 0db7bd8
gwtproject/gwt#9727: add package-info to jakarta package
sparsick ed48c54
gwtproject/gwt#9727: add package-info to jakarta package in javadoc u…
sparsick da6e94b
Merge branch '9727-jakarta-servlet-support' into 9727-jakarta-servlet…
sparsick 82dc435
gwtproject/gwt#9727 : move jakarata specific classes and their depend…
sparsick ae6b956
gwtproject/gwt#9727: adjust javadoc generation to match all jakarta r…
sparsick a1bc4e0
gwtproject/gwt#9727: adjust tools ref for testing
sparsick 27bf438
Reduce files that are moved, rewritten
niloc132 3d07693
Reuse the same sources generated for gwt-user when making javadoc
niloc132 48f4481
Split copied sources into "doesn't need changes" and "just for jakarta"
niloc132 8536d59
Cut another dependency on RPC
niloc132 a83167e
Generate a copy of the RPC AdvancedExample
niloc132 784ad49
gwtproject/gwt#9727: fix - wrong merging
sparsick d7f7f4b
Fix GwtServletBase
niloc132 195c749
Merge remote-tracking branch 'sparsick/9727-jakarta-servlet-support' …
niloc132 25665e0
Remove no-longer-correct note about javadoc being broken
niloc132 9835498
Use the same javadoc for all maven jars, and pack modified sources in
niloc132 7df339b
Draft of requestfactory-server jakarta variant
niloc132 25c2daf
Added package-info for new generated types, removed rf-log handler
niloc132 50ce8ff
Merge branch 'main' into 9727-jakarta-servlet-support
niloc132 5feafe4
Self-review of docs
niloc132 d0ec92b
Revert CI changes to use tools fork
niloc132 29dc223
Merge branch 'main' into 9727-jakarta-servlet-support
niloc132 2925e34
Fix checkstyle warning in javadoc
niloc132 f0eafec
Merge branch 'main' into 9727-jakarta-servlet-support
niloc132 50043a4
Fix extra chars in javadoc line
niloc132 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<project xmlns="http://maven.apache.org/POM/4.0.0" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> | ||
<modelVersion>4.0.0</modelVersion> | ||
<parent> | ||
<groupId>org.gwtproject</groupId> | ||
<artifactId>gwt</artifactId> | ||
<version>${gwtVersion}</version> | ||
</parent> | ||
<groupId>org.gwtproject</groupId> | ||
<artifactId>gwt-servlet-jakarta</artifactId> | ||
<packaging>jar</packaging> | ||
<version>${gwtVersion}</version> | ||
<dependencies> | ||
<dependency> | ||
<groupId>javax.validation</groupId> | ||
<artifactId>validation-api</artifactId> | ||
<!-- needed by RequestFactory --> | ||
<optional>true</optional> | ||
</dependency> | ||
<dependency> | ||
<groupId>com.google.code.gson</groupId> | ||
<artifactId>gson</artifactId> | ||
<!-- Used for source-mapping in stacktrace deobfuscation for logging --> | ||
<optional>true</optional> | ||
</dependency> | ||
</dependencies> | ||
</project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<project xmlns="http://maven.apache.org/POM/4.0.0" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> | ||
<modelVersion>4.0.0</modelVersion> | ||
<parent> | ||
<groupId>org.gwtproject.web.bindery</groupId> | ||
<artifactId>requestfactory</artifactId> | ||
<version>${gwtVersion}</version> | ||
</parent> | ||
<groupId>org.gwtproject.web.bindery</groupId> | ||
<artifactId>requestfactory-server-jakarta</artifactId> | ||
<packaging>jar</packaging> | ||
<version>${gwtVersion}</version> | ||
<dependencies> | ||
<dependency> | ||
<groupId>javax.validation</groupId> | ||
<artifactId>validation-api</artifactId> | ||
</dependency> | ||
<dependency> | ||
<groupId>com.google.code.gson</groupId> | ||
<artifactId>gson</artifactId> | ||
<!-- Used for source-mapping in stacktrace deobfuscation for logging --> | ||
<optional>true</optional> | ||
</dependency> | ||
</dependencies> | ||
</project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if #9785 lands, this will need the same change.