Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save statmap significance fits information #4951

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GarethCabournDavies
Copy link
Contributor

The significance fits information gets discarded and there is not way to get it back - this change saves the fit coefficient, its approximate error and the rate of triggers above threshold as attributes in the statmap output files

Standard information about the request

This is an information loss bug fix
This change affects the offline search
This change changes: output which can be used for later review / plotting

This change follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines

Motivation

We want to be able to get the FAR calculation extrapolation values for review etc.
We can reverse-engineer fit coefficient and count above threshold using e.g. the FAR / stat values above the threshold, but not the error on fit coefficient

Contents

Add a significance info dictionary as output from the get_far function
Report the values in this dictionary into the attributes of the various statmap job outputs

Testing performed

tested for sngls_statmap outputs, ensuring that these match reverse-engineered outputs

  • The author of this pull request confirms they will adhere to the code of conduct

@GarethCabournDavies GarethCabournDavies added offline search v23_release_branch PRs applied to the v2.3.X release branch or to be cherry-picked if merging to master labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
offline search v23_release_branch PRs applied to the v2.3.X release branch or to be cherry-picked if merging to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant