Save statmap significance fits information #4951
Open
+59
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The significance fits information gets discarded and there is not way to get it back - this change saves the fit coefficient, its approximate error and the rate of triggers above threshold as attributes in the statmap output files
Standard information about the request
This is an information loss bug fix
This change affects the offline search
This change changes: output which can be used for later review / plotting
This change follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
Motivation
We want to be able to get the FAR calculation extrapolation values for review etc.
We can reverse-engineer fit coefficient and count above threshold using e.g. the FAR / stat values above the threshold, but not the error on fit coefficient
Contents
Add a significance info dictionary as output from the get_far function
Report the values in this dictionary into the attributes of the various statmap job outputs
Testing performed
tested for sngls_statmap outputs, ensuring that these match reverse-engineered outputs