-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for OSDF support #4459
Merged
Merged
Changes for OSDF support #4459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be ready to merge, and I would like to get it into a forthcoming release as it will allow more efficient access to frame files. (This may also be implemented in GWOSC, which would also help). |
ahnitz
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me.
GarethCabournDavies
pushed a commit
to GarethCabournDavies/pycbc
that referenced
this pull request
Oct 11, 2023
* Changes for OSDF support * Bump version here as well * Add OSDF handling in workflow.datafind * Add OSDF handling * Add in OSDF transfer code * Make OSDF local transfers work * Code Climating * Should include IGWN requirements * Trying to fix failures * Revert moving ciecplib import * Missed undoing this change
PRAVEEN-mnl
pushed a commit
to PRAVEEN-mnl/pycbc
that referenced
this pull request
Nov 3, 2023
* Changes for OSDF support * Bump version here as well * Add OSDF handling in workflow.datafind * Add OSDF handling * Add in OSDF transfer code * Make OSDF local transfers work * Code Climating * Should include IGWN requirements * Trying to fix failures * Revert moving ciecplib import * Missed undoing this change
bhooshan-gadre
pushed a commit
to bhooshan-gadre/pycbc
that referenced
this pull request
Mar 4, 2024
* Changes for OSDF support * Bump version here as well * Add OSDF handling in workflow.datafind * Add OSDF handling * Add in OSDF transfer code * Make OSDF local transfers work * Code Climating * Should include IGWN requirements * Trying to fix failures * Revert moving ciecplib import * Missed undoing this change
acorreia61201
pushed a commit
to acorreia61201/pycbc
that referenced
this pull request
Apr 4, 2024
* Changes for OSDF support * Bump version here as well * Add OSDF handling in workflow.datafind * Add OSDF handling * Add in OSDF transfer code * Make OSDF local transfers work * Code Climating * Should include IGWN requirements * Trying to fix failures * Revert moving ciecplib import * Missed undoing this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for OSDF (https://portal.osg-htc.org/documentation/htc_workloads/managing_data/osdf/) transfers in PyCBC.workflow.
Pegasus added OSDF support in 5.0.6 (hence the version bump), but we need a few pointers to make it work as intended.
This is now ready to merge because we have fixed: