added color options in pycbc_inference_plot_posterior function #4264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@divyajyoti09 It looks like this fell through the cracks and never got assigned a reviewer. An obvious problem with the PR is that it adds a bunch of C codes that are intermediate products and should not be part of PyCBC. Can these be removed from the PR, and the PR rebased to the current main branch? I've asked @ahnitz and @cdcapano to look at this, but I think the changes to the plotting code make sense and add features. |
|
@divyajyoti09 Can you address the issues that @spxiwh raised so we can merge the improvements you've made? |
spxiwh
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
This looks good now, and in the absence of any further comments, I'll merge this now. Thanks @divyajyoti09
GarethCabournDavies
pushed a commit
to GarethCabournDavies/pycbc
that referenced
this pull request
Oct 11, 2023
…ro#4264) * added color options in pycbc_inference_plot_posterior function * added color options for 1D histograms * testing authentication token * cleaning up * bug fix * deleting unnecessary c files
PRAVEEN-mnl
pushed a commit
to PRAVEEN-mnl/pycbc
that referenced
this pull request
Nov 3, 2023
…ro#4264) * added color options in pycbc_inference_plot_posterior function * added color options for 1D histograms * testing authentication token * cleaning up * bug fix * deleting unnecessary c files
bhooshan-gadre
pushed a commit
to bhooshan-gadre/pycbc
that referenced
this pull request
Mar 4, 2024
…ro#4264) * added color options in pycbc_inference_plot_posterior function * added color options for 1D histograms * testing authentication token * cleaning up * bug fix * deleting unnecessary c files
acorreia61201
pushed a commit
to acorreia61201/pycbc
that referenced
this pull request
Apr 4, 2024
…ro#4264) * added color options in pycbc_inference_plot_posterior function * added color options for 1D histograms * testing authentication token * cleaning up * bug fix * deleting unnecessary c files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional argument added to
pycbc_inference_plot_posteriorfunction so that in case of multiple injections, the user has the option to choose colors. Default (when that argument is not provided) is to use the existing code, which at the moment chooses colors according to the matplotlib color cycle.