Filtering improvements #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Array is always filtered when the filtered array is required. This is an overhead when the data has 100k of words. It’s too slow and blocks UI thread. This should be like filter the array and store in controller and used that private filtered array when required. Do not need to filter an filter again.
|
+10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array is filtered every time when the filtered array is required. This is an overhead when application provides a list of 100k words. It works slowly and blocks UI thread.
Words list should be filtered once and stored as instance variable. If this array is required, this instance variable can be invoked. There is no need to filter and filter again list of words for the same text.