Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding to frame-title-format when it has been customized in certain ways #33

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

gvol
Copy link
Owner

@gvol gvol commented Apr 7, 2024

The customization could be a single (:eval ...) construct, for example. There doesn't seem to be any problems nesting lists arbitrarily deep, though it may impact performance if it happened too much.

Fixes #20

The customization could be a single (:eval ...) construct, for example.
There doesn't seem to be any problems nesting lists arbitrarily deep,
though it may impact performance if it happened too much.

Fixes #20
@lassik
Copy link
Collaborator

lassik commented Apr 7, 2024

Maybe best to provide memento-mori-mode-line-construct and memento-mori-frame-title-construct which the user can add where he pleases? It seems difficult to anticipate all use cases and interactions with other elisp packages and customizations.

@lassik
Copy link
Collaborator

lassik commented Apr 7, 2024

The docstring for mode-line-format says:

For any symbol other than t or nil, the symbol’s value is processed as a mode line construct.

@lassik
Copy link
Collaborator

lassik commented Apr 7, 2024

The standard value of mode-line-format uses many such symbols:

mode-line-buffer-identification
mode-line-client
mode-line-frame-identification
mode-line-misc-info
mode-line-modified
mode-line-mule-info
mode-line-position
mode-line-remote

Following this precedent, perhaps info is an easier word than construct.

@gvol
Copy link
Owner Author

gvol commented Apr 26, 2024

Thanks for your feedback @lassik. I added some verbiage about using memento-mori-mode-line to manually update the mode line. I still like having the easy to use variable there to turn it on and off, so that hopefully people can easily experiment with it in the Customize buffer.

@gvol gvol merged commit 424dc59 into master Apr 29, 2024
12 checks passed
@gvol gvol deleted the 89f0a96 branch April 29, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memento-mori-string not displaying in frame title
2 participants