Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some warnings #30

Merged
merged 2 commits into from
Apr 7, 2024
Merged

Fix some warnings #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb3fc02
Fix some warnings
Apr 7, 2024
f5291a5
Fix a long line warning
Apr 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions memento-mori.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
:group 'help)

(defcustom memento-mori-display-in-modeline t
"If non-nil, `memento-mori-mode' will add mementos to the mode line.

Check warning on line 56 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (24.4, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 56 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (25.1, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 56 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.1, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 56 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.2, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 56 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.3, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 56 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (27.1, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 56 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (27.2, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.
Really, it adds it to the `global-mode-string', which usually
appears in the mode line, however, if you have customized your
mode line it may not appear."
Expand All @@ -63,7 +63,7 @@
:initialize #'custom-initialize-default)

(defcustom memento-mori-display-in-frame-title nil
"If non-nil, `memento-mori-mode' will add mementos to the frame title."

Check warning on line 66 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (24.4, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 66 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (25.1, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 66 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.1, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 66 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.2, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 66 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.3, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 66 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (27.1, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 66 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (27.2, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.
:group 'memento-mori
:type 'boolean
:set #'memento-mori--set-value-and-update-display
Expand Down Expand Up @@ -256,12 +256,12 @@
(defvar memento-mori-string ""
"The memento mori memento.
The string shown in the mode line and/or frame title when
`memento-mori-mode' is enabled. This is not meant to be changed

Check warning on line 259 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (24.4, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 259 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (25.1, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 259 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.1, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 259 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.2, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 259 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.3, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 259 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (27.1, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.

Check warning on line 259 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (27.2, false) 

Disambiguate memento-mori-mode by preceding w/ function,command,variable,option or symbol.
by the user, but can be used in other places such as org-mode
by the user, but can be used in other places such as `org-mode'
agendas to display the current momento.")

(defun memento-mori--set-value-and-update-display (symbol value)
"Function to set display values, so that the display will then be recalculated.
"Function to set display values, so the display will then be recalculated.
Sets SYMBOL to VALUE, then calls updates `memento-mori--add-mementos'."
(set-default-toplevel-value symbol value)
(memento-mori--add-mementos))
Expand Down Expand Up @@ -301,9 +301,9 @@
(error "Birth date not set. Try M-x customize-group memento-mori")))

(defun memento-mori--parse-time (value)
"Return your birth time in `encode-time' format.
The birth time is parsed from `memento-mori-birth-date' using
`parse-time-string'. An error is signaled if it is not valid."
"Return time in `encode-time' format.
The time is parsed from VALUE using `parse-time-string'.
An error is signaled if it is not valid."
(when (symbolp value)
(setq value (symbol-value value)))
(let* ((decoded (parse-time-string
Expand Down Expand Up @@ -373,7 +373,7 @@
(/ since-seconds (* 60 60 24))
days))
(t 0)))))
(format-spec format-string

Check warning on line 376 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (24.4, false) 

format-spec called with 3 arguments, but accepts only 2

Check warning on line 376 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (25.1, false) 

format-spec called with 3 arguments, but accepts only 2

Check warning on line 376 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.1, false) 

format-spec called with 3 arguments, but accepts only 2

Check warning on line 376 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.2, false) 

format-spec called with 3 arguments, but accepts only 2

Check warning on line 376 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.3, false) 

format-spec called with 3 arguments, but accepts only 2
`((?Y . ,years)
(?y . ,(truncate years))
(?M . ,months)
Expand Down Expand Up @@ -412,7 +412,7 @@
(when (and memento-mori-initial-scratch-message
(boundp 'initial-scratch-message))
(setq initial-scratch-message
(format-spec memento-mori-initial-scratch-message

Check warning on line 415 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (24.4, false) 

format-spec called with 3 arguments, but accepts only 2

Check warning on line 415 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (25.1, false) 

format-spec called with 3 arguments, but accepts only 2

Check warning on line 415 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.1, false) 

format-spec called with 3 arguments, but accepts only 2

Check warning on line 415 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.2, false) 

format-spec called with 3 arguments, but accepts only 2

Check warning on line 415 in memento-mori.el

View workflow job for this annotation

GitHub Actions / check (26.3, false) 

format-spec called with 3 arguments, but accepts only 2
`((?m . ,memento-mori-string)
(?q . ,(memento-mori--random-quote)))
'ignore))))
Expand Down
Loading