Fix various warnings

README.md

@@ -74,3 +74,13 @@ desired reflection.
 
 If the mode-line is too much, you could add it to your
 `org-agenda-custom-commands` or similar.
+
+You can also set memento-mori-initial-scratch-message to a format something like
+"%q\n\n%m\n" so that the initial scratch buffer will contain a random quote
+followed by the current memento.
+
+## Contributing
+
+Feel free to open issues, pull requests, etc.  In particular, I'm sure there are
+many good quotes that I didn't include in `memento-mori-quotes`, so please send
+them in!  Also if you have a good memento, I would love to have those too.

memento-mori.el

@@ -53,7 +53,7 @@
   :group 'help)
 
 (defcustom memento-mori-display-in-modeline t
   "If non-nil, `memento-mori-mode' will add mementos to the mode line.
 Really, it adds it to the `global-mode-string', which usually
 appears in the mode line, however, if you have customized your
 mode line it may not appear."
@@ -61,7 +61,7 @@
   :type 'boolean)
 
 (defcustom memento-mori-display-in-frame-title nil
   "If non-nil, `memento-mori-mode' will add mementos to the frame title."
   :group 'memento-mori
   :type 'boolean)
 
@@ -247,8 +247,8 @@
 (defvar memento-mori-string ""
   "The memento mori memento.
 The string shown in the mode line and/or frame title when
 `memento-mori-mode' is enabled.  This is not meant to be changed
 by the user, but can be used in other places such as org-mode
 agendas to display the current momento.")
 
 (defvar memento-mori--modeline-construct
@@ -280,7 +280,7 @@
     (error "Birth date not set.  Try M-x customize-group memento-mori")))
 
 (defun memento-mori--parse-time (value)
   "Return your birth time in `encode-time' format.
 The birth time is parsed from `memento-mori-birth-date' using
 `parse-time-string'.  An error is signaled if it is not valid."
   (when (symbolp value)
@@ -314,7 +314,7 @@
   "Randomly choose a quote from `memento-mori-quotes'."
   (nth (random (length memento-mori-quotes)) memento-mori-quotes))
 
 (defun memento-mori--format-memento (memento)
   "Format MEMENTO based on the current time."
   (let* ((format-string (car memento))
          (args-plist (cdr memento))
@@ -322,7 +322,7 @@
          (since-value (plist-get args-plist :since))
          (_ (when (not (or until-value since-value))
                  (error ":since or :until required.  Parsing %s" memento)))
          (current-time-list nil)
          (until-seconds (when until-value
                           (float-time
                            (time-subtract
@@ -353,7 +353,7 @@
                                      (/ since-seconds (* 60 60 24))
                                      days))
                            (t 0)))))
     (format-spec format-string
                  `((?Y . ,years)
                    (?y . ,(truncate years))
                    (?M . ,months)
@@ -370,6 +370,9 @@
                    (?p . ,(truncate percent)))
                  'ignore)))
 
+;; Forward declare initial-scratch-message which should be defined at run time
+(defvar initial-scratch-message)
+
 (defun memento-mori--update ()
   "Update `memento-mori-string' based on the current time."
   (let ((has-set-new (not (eq memento-mori-mementos
@@ -389,13 +392,13 @@
   (when (and memento-mori-initial-scratch-message
              (boundp 'initial-scratch-message))
     (setq initial-scratch-message
           (format-spec memento-mori-initial-scratch-message
                        `((?m . ,memento-mori-string)
                          (?q . ,(memento-mori--random-quote)))
                        'ignore))))
 
 (defun memento-mori--add-mementos ()
-  "Adds constructs to mode line and/or frame title to display `memento-mori-mementos'.
+  "Adds constructs to mode line and/or frame title to display mementos.
 Where it adds it is controlled by `memento-mori-display-in-modeline' and
 `memento-mori-display-in-frame-title' respectively.