Merge pull request #10 from gvallee/topic/slurm_improved_bin_arg_mgt

Slightly better management of binary's arguments in the context of SLURM
gvallee · Jun 13, 2022 · d428939 · d428939
2 parents a7107d0 + 3db0cb0
commit d428939
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/jm/jobmgr_slurm.go b/pkg/jm/jobmgr_slurm.go
@@ -282,7 +282,11 @@ func setupMpiJob(j *job.Job, sysCfg *sys.Config) error {
 		ppr := j.NP / j.NNodes
 		scriptText += fmt.Sprintf("--map-by ppr:%d:node -rank-by core -bind-to core", ppr)
 	}
-	scriptText += " " + strings.Join(mpirunArgs, " ") + " " + j.App.BinPath + strings.Join(j.App.BinArgs," ") + "\n"
+	scriptText += " " + strings.Join(mpirunArgs, " ") + " " + j.App.BinPath
+	if len(j.App.BinArgs) > 0 {
+		scriptText += " " + strings.Join(j.App.BinArgs, " ")
+	}
+	scriptText += "\n"
 
 	err = ioutil.WriteFile(j.BatchScript, []byte(scriptText), 0644)
 	if err != nil {