Extend codec support for CSA file parsing #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunyarakun
requested changes
Feb 23, 2022
| return Parser.parse_str(f.read()) | ||
| except: | ||
| pass | ||
| return None |
There was a problem hiding this comment.
It would be great if the function raises an exception when we cannot decode as cp932 and utf-8-sig instead of returning None.
|
@yoshi486x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When trying to parse CSA file in a Windows environment, the below error appeared due to not specifying the encoding format.
Solution
This fix will specify the two encoding formats already used to parse a KIF file which are 'cp932' and 'utf-8-sig'.