Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid problems with FastVerticalInterpHistPdf2Base initialization
Browse files Browse the repository at this point in the history
The `_sentry` is already filled when calling `evaluate()`, so no need to
do that in the copy constructor. Doing so can actually leading to
redundant calls to `_sentry.addVars(_coefList)`, resulting in the
problem reported here:
cms-analysis#940 (comment)
```
[#0] ERROR:InputArguments -- RooArgSet::checkForDup: ERROR argument with name CMS_vhbb_stats_TT_ZmmLoose7TeV is already in this set
```
guitargeek committed Jun 4, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 07b69ab commit 266f3ad
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions src/VerticalInterpHistPdf.cc
Original file line number Diff line number Diff line change
@@ -772,14 +772,9 @@ FastVerticalInterpHistPdf2Base::FastVerticalInterpHistPdf2Base(const FastVertica
_coefList("coefList", this, other._coefList),
_smoothRegion(other._smoothRegion),
_smoothAlgo(other._smoothAlgo),
_initBase(other._initBase),
_initBase(false),
_morphs(other._morphs), _morphParams(other._morphParams)
{
if (_initBase) {
// Morph params are already set, but we must set the sentry
_sentry.addVars(_coefList);
_sentry.setValueDirty();
}
}

//_____________________________________________________________________________

0 comments on commit 266f3ad

Please sign in to comment.