fix(16294): update interface to include target prop in switcheritem t…

…ype (carbon-design-system#16295) Co-authored-by: Nikhil Tomar <[email protected]> Co-authored-by: Guilherme Datilio Ribeiro <[email protected]> Co-authored-by: Taylor Jones <[email protected]>
guidari · May 22, 2024 · cfb682c · cfb682c
1 parent db816e6
commit cfb682c
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 1 deletion.
diff --git a/.all-contributorsrc b/.all-contributorsrc
@@ -1517,6 +1517,15 @@
       ]
     },
     {
+      "login": "ahmedsemih",
+      "name": "Ahmed Semih Erkan",
+      "avatar_url": "https://avatars.githubusercontent.com/u/102798814?v=4",
+      "profile": "https://github.com/ahmedsemih",
+      "contributions": [
+        "code"
+      ]
+     },
+    {  
       "login": "ychavoya",
       "name": "Yael Chavoya",
       "avatar_url": "https://avatars.githubusercontent.com/u/7907338?v=4",

diff --git a/README.md b/README.md
@@ -289,6 +289,7 @@ check out our [Contributing Guide](/.github/CONTRIBUTING.md) and our
     <td align="center"><a href="https://hollyos.com/"><img src="https://avatars.githubusercontent.com/u/4097509?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Holly Springsteen</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=hollyos" title="Code">💻</a></td>
     <td align="center"><a href="https://github.com/2nikhiltom"><img src="https://avatars.githubusercontent.com/2nikhiltom?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Nikhil Tomar</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=2nikhiltom" title="Code">💻</a></td>
     <td align="center"><a href="https://github.com/aninaantony"><img src="https://avatars.githubusercontent.com/u/164350784?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Anina Antony</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=aninaantony" title="Code">💻</a></td>
+    <td align="center"><a href="https://github.com/ahmedsemih"><img src="https://avatars.githubusercontent.com/u/102798814?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Ahmed Semih Erkan</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=ahmedsemih" title="Code">💻</a></td>
     <td align="center"><a href="https://github.com/ychavoya"><img src="https://avatars.githubusercontent.com/u/7907338?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Yael Chavoya</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=ychavoya" title="Code">💻</a></td>
     <td align="center"><a href="https://github.com/Kilian-Collender"><img src="https://avatars.githubusercontent.com/u/37899503?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Kilian Collender</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=Kilian-Collender" title="Code">💻</a></td>
   </tr>

diff --git a/packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap b/packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap
@@ -7528,6 +7528,9 @@ Map {
       "tabIndex": Object {
         "type": "number",
       },
+      "target": Object {
+        "type": "string",
+      },
     },
     "render": [Function],
   },

diff --git a/packages/react/src/components/UIShell/SwitcherItem.tsx b/packages/react/src/components/UIShell/SwitcherItem.tsx
@@ -1,4 +1,8 @@
-import React, { ElementType, forwardRef } from 'react';
+import React, {
+  ElementType,
+  forwardRef,
+  HTMLAttributeAnchorTarget,
+} from 'react';
 import cx from 'classnames';
 import PropTypes from 'prop-types';
 import Link from './Link';
@@ -50,6 +54,10 @@ interface BaseSwitcherItemProps {
    * Optionally provide an href for the underlying li`
    */
   href?: string;
+  /**
+   * Specify where to open the link.
+   */
+  target?: HTMLAttributeAnchorTarget;
 }
 
 interface SwitcherItemWithAriaLabel extends BaseSwitcherItemProps {
@@ -80,6 +88,7 @@ const SwitcherItem = forwardRef<ElementType, SwitcherItemProps>(
       handleSwitcherItemFocus,
       onKeyDown = () => {},
       href,
+      target,
       ...rest
     } = props;
 
@@ -122,6 +131,7 @@ const SwitcherItem = forwardRef<ElementType, SwitcherItemProps>(
             onKeyDown(evt);
           }}
           href={href}
+          target={target}
           ref={forwardRef}
           {...rest}
           className={linkClassName}
@@ -169,6 +179,10 @@ SwitcherItem.propTypes = {
    * Specify the tab index of the Link
    */
   tabIndex: PropTypes.number,
+  /**
+   * Specify where to open the link.
+   */
+  target: PropTypes.string,
 };
 
 export default SwitcherItem;