fix: makes aria-label optional (carbon-design-system#17467)

guidari · Sep 19, 2024 · 7956f63 · 7956f63
1 parent fab91fa
commit 7956f63
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/react/src/components/DataTable/TableExpandHeader.tsx b/packages/react/src/components/DataTable/TableExpandHeader.tsx
@@ -31,7 +31,7 @@ type TableExpandHeaderPropsBase = {
    * Specify the string read by a voice reader when the expand trigger is
    * focused
    */
-  ['aria-label']: string;
+  ['aria-label']?: string;
 
   /**
    * @deprecated The enableExpando prop is being replaced by `enableToggle`
@@ -150,7 +150,7 @@ TableExpandHeader.propTypes = {
   className: PropTypes.string,
 
   /**
-   * The enableExpando prop is being replaced by enableToggle
+   * The enableExpando prop is being replaced by TableExpandHeader
    */
   enableExpando: deprecate(
     PropTypes.bool,

diff --git a/packages/react/src/components/DataTable/__tests__/TableExpandHeader-test.js b/packages/react/src/components/DataTable/__tests__/TableExpandHeader-test.js
@@ -31,7 +31,7 @@ describe('TableExpandHeader', () => {
           <TableHead>
             <TableRow>
               <TableExpandHeader
-                ariaLabel="test-label"
+                aria-label="test-label"
                 isExpanded={false}
                 onExpand={jest.fn()}
                 className="custom-class"
@@ -43,12 +43,12 @@ describe('TableExpandHeader', () => {
       expect(container).toMatchSnapshot();
     });
 
-    it('should respect ariaLabel prop', () => {
+    it('should respect aria-label prop', () => {
       render(
         <Table>
           <TableHead>
             <TableRow>
-              <TableExpandHeader isExpanded enableToggle ariaLabel="Expand" />
+              <TableExpandHeader isExpanded aria-label="Expand" enableToggle />
             </TableRow>
           </TableHead>
         </Table>