Skip to content

guardrails-test/thomas_rnd

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

43 Commits
 
 
 
 
 
 
 
 
 
 

Repository files navigation

GuardRails Technical Test

Description

This project is made in accordance with the requirements of the following exercice

Setup

Run docker-compose up to start the containers. The dashboard is accessible at the following url http://localhost:3000 .

Improvements

For the API

  • Scan Service: We could improve the logic in there to have less random results and maybe have something more sequential ( queued > scanning > result).
  • Auth: An Auth service could be added to manage users and their scanning results.
  • Migrations: Implementing a migration system for the models with sequelize.

For the Dashboard

  • ScanDetails State Management: Instead of loading all the data at once from the Dashboard, we could fetch only the required data for ScanList and then individually fetch the findings only when the corresponding ScanDetails component is displayed (This is not relevant if the number of findings stays relatively low for each repo).
  • Error Handling: The logic for handling axios request and the errors should be implemented in a separate file

For Docker

  • React HMR: The HMR does not currently work when the dashboard is running in the container
  • [FIXED] DB Data persistence: The data is erased from the DB when the container is stopped.

About

No description, website, or topics provided.

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published