Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Migrate to GitHub CI #523

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

WIP: Migrate to GitHub CI #523

wants to merge 3 commits into from

Conversation

frazierbaker
Copy link
Collaborator

No description provided.

@frazierbaker
Copy link
Collaborator Author

frazierbaker commented Apr 3, 2021

The GitHub CI should work for free with a couple of caveats:

  1. The build time for a single job cannot exceed 6 hours.
  2. The docker pushes will not work without credentials to upload to dockerhub. I have a multiplatformautonomy organization set up on DockerHub that is slightly more generic, though it may be worth having GTRI setting up a GTRI dockerhub organization and supplying build keys via a GitHub secret (GitHub secrets will be redacted in any logs they show up in). If GTRI doesn't want to do this, then I need admin access to the repository to add my generated DockerHub credentials as a secret.

@frazierbaker frazierbaker marked this pull request as draft April 3, 2021 04:18
@frazierbaker
Copy link
Collaborator Author

@SyllogismRXS
Copy link
Contributor

Maybe ask @esquires about the test_auction fail. Pretty sure he put that one together.

@SyllogismRXS
Copy link
Contributor

@frazierbaker Is GTRI going to setup a DockerHub account? I think that would be ideal.

@frazierbaker
Copy link
Collaborator Author

@SyllogismRXS I agree that that would be ideal, we are working on that. @esquires any advice on the rostests?

@esquires
Copy link
Collaborator

esquires commented May 3, 2021

I am not sure unfortunately. I would run the test individually to see the cout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants