Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix Path setting on windows #1675

Merged
merged 1 commit into from
Apr 2, 2024
Merged

docs: fix Path setting on windows #1675

merged 1 commit into from
Apr 2, 2024

Conversation

mokurin000
Copy link
Contributor

@mokurin000 mokurin000 commented Apr 2, 2024 •
edited
Loading

As said in #1645, the Path in gtk book Windows setup guide should be C:\gtk-build\gtk\x64\release\bin, where the pkg-config.exe actually placed

@mokurin000 mokurin000 requested a review from Hofer-Julian as a code owner April 2, 2024 18:14
Hofer-Julian
Hofer-Julian approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Hofer-Julian Hofer-Julian merged commit 6a7f477 into gtk-rs:master Apr 2, 2024
2 checks passed
@bilelmoussaoui
Copy link
Member

Should the linked issue be closed then?

@mokurin000 mokurin000 deleted the patch-1 branch April 2, 2024 21:41
@Hofer-Julian Hofer-Julian mentioned this pull request Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hofer-Julian Hofer-Julian Hofer-Julian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mokurin000 @bilelmoussaoui @Hofer-Julian