Expose dbus_register and dbus_unregister vfuncs #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is my first time doing glib FFI, so I'd like ask for a careful review, especially around ownership of pointers. If this is accepted I'd very much appreciate a timely backport and release, as I need this to reliably export an object on the bus in my code. |
|
Mmh, did I cause this CI error? |
No, the docs job is just randomly failing. |
sdroege
reviewed
Jan 21, 2025
sdroege
reviewed
Jan 21, 2025
sdroege
reviewed
Jan 21, 2025
sdroege
reviewed
Jan 21, 2025
sdroege
reviewed
Jan 21, 2025
sdroege
reviewed
Jan 21, 2025
swsnr
force-pushed
the
dbus_register_vfunc
branch
from
179386b to
f40c7d4
Compare
|
@bilelmoussaoui @sdroege I think I addressed everything. I added name_lost too; I hope I did it right, because I didn't really understand what the return value does and it doesn't seem to be documented 🤷 |
swsnr
force-pushed
the
dbus_register_vfunc
branch
from
77d82c5 to
325e4c0
Compare
swsnr
commented
Jan 22, 2025
sdroege
reviewed
Jan 22, 2025
sdroege
reviewed
Jan 22, 2025
swsnr
force-pushed
the
dbus_register_vfunc
branch
from
325e4c0 to
e7fef77
Compare
This is more in line how application classes would be used in real world applications which usually create a derived application class which holds the overall state. And it prepares for testing the dbus_register vfunc subsequently.
swsnr
force-pushed
the
dbus_register_vfunc
branch
from
e7fef77 to
00fe956
Compare
swsnr
commented
Jan 22, 2025
|
While I was at it I've pushed another commit which replaces the IOErrorEnum's in the DBus example with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this vfunc makes exporting objects on the app's bus name much easier and more reliable.
I've rewritten the corresponding example to use these two methods, as the GIO docs recommend to use these vfuncs for object registration. Also, registering an object in startup is prone to race conditions wrt to bus ownership as the object gets registered only after the application claimed the bus name.