Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional type bounds to Impl traits #1519

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Add additional type bounds to Impl traits #1519

merged 3 commits into from
Oct 3, 2024

Conversation

felinira
Copy link
Contributor

See #1515

sdroege
sdroege reviewed Sep 29, 2024
View reviewed changes
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically the same comments to everything :)

gdk-pixbuf/src/subclass/pixbuf_animation.rs Outdated Show resolved Hide resolved
gdk-pixbuf/src/subclass/pixbuf_animation.rs Show resolved Hide resolved
gio/src/subclass/action_group.rs Outdated Show resolved Hide resolved
@felinira felinira force-pushed the wip/impl-trait-bounds branch 2 times, most recently from f30a7aa to bf09d82 Compare September 29, 2024 14:39
@felinira
Copy link
Contributor Author

felinira commented Sep 29, 2024 •
edited
Loading

I removed all sealed traits except for the one for ObjectImplExt, which I am unsure about. But I don't see much harm in that one.

@sdroege
Copy link
Member

sdroege commented Sep 29, 2024

I removed all sealed traits except for the one for ObjectImplExt, which I am unsure about. But I don't see much harm in that one.

What's different with that one? Seems like the others to me and should be fine with just the : ObjectImpl + ObjectSubclass trait bound

@felinira felinira force-pushed the wip/impl-trait-bounds branch from bf09d82 to 03bdfd2 Compare September 29, 2024 16:10
@felinira
Copy link
Contributor Author

What's different with that one?

You're right. I was thinking because you don't need to specify them in the wrapper macro, but that's unrelated.

@felinira felinira force-pushed the wip/impl-trait-bounds branch from 03bdfd2 to d997c25 Compare September 29, 2024 18:00
@felinira
Copy link
Contributor Author

felinira commented Sep 29, 2024 •
edited
Loading

As discussed on matrix, I added additional IsA<glib::Object> trait bounds. This should be ready now.

@felinira felinira force-pushed the wip/impl-trait-bounds branch from d997c25 to 0575a08 Compare September 29, 2024 18:07
sdroege
sdroege previously approved these changes Sep 30, 2024
View reviewed changes
@sdroege sdroege force-pushed the wip/impl-trait-bounds branch from 0575a08 to f065259 Compare September 30, 2024 09:19
@sdroege
Copy link
Member

sdroege commented Sep 30, 2024

Some failing tests :)

@felinira felinira force-pushed the wip/impl-trait-bounds branch from f065259 to 7e1f8dc Compare October 3, 2024 14:25
@felinira felinira force-pushed the wip/impl-trait-bounds branch from 7e1f8dc to 07dbf34 Compare October 3, 2024 14:25
@sdroege sdroege merged commit 5ec8462 into gtk-rs:master Oct 3, 2024
48 checks passed
This was referenced Oct 3, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdroege sdroege sdroege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felinira @sdroege