-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glib/GStringPtr: Add as_str()
and Deref<Target=&str>
#1181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also BTW I didn't test this locally as I'm hitting a crate build error locally; I haven't dug in yet EDIT: See #1185
|
This was referenced Sep 12, 2023
What's the status here? |
cgwalters
force-pushed
the
gstring-as-str
branch
from
September 25, 2023 12:43
9b24a35
to
111554e
Compare
Now that I can build locally, updated to fix the infinite recursion in |
bilelmoussaoui
added
the
needs-backport
PR needs backporting to the current stable branch
label
Sep 25, 2023
I was updating some code to glib 0.18 and we were previously using `as_str()` - which is what the default Rust nomenclature for an *infallible* reference-to-reference conversion uses. The `to_str()` is used for fallible conversions (e.g. https://doc.rust-lang.org/std/ffi/struct.OsStr.html#method.to_str) which this is not.
cgwalters
force-pushed
the
gstring-as-str
branch
from
September 25, 2023 13:26
111554e
to
dc856e5
Compare
bilelmoussaoui
approved these changes
Sep 25, 2023
sdroege
approved these changes
Sep 25, 2023
sdroege
removed
the
needs-backport
PR needs backporting to the current stable branch
label
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was updating some code to glib 0.18 and we were previously using
as_str()
- which is what the default Rust nomenclature for an infallible reference-to-reference conversion uses.The
to_str()
is used for fallible conversions(e.g. https://doc.rust-lang.org/std/ffi/struct.OsStr.html#method.to_str) which this is not.