Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate with latest gir/gir-files #1155

Merged
merged 19 commits into from
Sep 27, 2023
Merged

Regenerate with latest gir/gir-files #1155

merged 19 commits into from
Sep 27, 2023

Conversation

bilelmoussaoui
Copy link
Member

No description provided.

@bilelmoussaoui bilelmoussaoui added the needs-backport PR needs backporting to the current stable branch label Aug 6, 2023
sdroege
sdroege reviewed Aug 7, 2023
View reviewed changes
glib/src/auto/functions.rs Outdated Show resolved Hide resolved
@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/regen branch 3 times, most recently from 4f52980 to 15dddec Compare August 27, 2023 13:02
@sdroege
Copy link
Member

sdroege commented Aug 28, 2023

Looks good to me, just need to get gobject-introspection fixed.

@sdroege
Copy link
Member

sdroege commented Sep 26, 2023

@bilelmoussaoui This is ready now?

@bilelmoussaoui
Copy link
Member Author

Yes, should be all good

@sdroege
Copy link
Member

sdroege commented Sep 26, 2023

Nice, will review some time later today :)

@sdroege
Copy link
Member

sdroege commented Sep 27, 2023

This is marked needs-backport but contains breaking changes (dropping of the Display impls at least). Needs special care when backporting to only include the OK changes.

@sdroege
Copy link
Member

sdroege commented Sep 27, 2023

I'll update this and then merge

@sdroege sdroege merged commit 548955f into master Sep 27, 2023
47 of 48 checks passed
@sdroege sdroege deleted the bilelmoussaoui/regen branch September 27, 2023 08:12
@sdroege
Copy link
Member

sdroege commented Sep 27, 2023

@bilelmoussaoui can you make a backport PR of this with the things that should be included?

@bilelmoussaoui
Copy link
Member Author

@sdroege i don't think there is much to backport actually, the time i put the label i thought remove display was not a breaking change :P

@sdroege
Copy link
Member

sdroege commented Sep 27, 2023

Yeah I was wondering which changes you wanted to backport. Let's not do that then :)

@sdroege sdroege removed the needs-backport PR needs backporting to the current stable branch label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdroege sdroege sdroege left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bilelmoussaoui @sdroege