IDP-2284 Use github action to increment tag versions on merge #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samrobillard
approved these changes
Sep 27, 2024
asimmon
reviewed
Sep 27, 2024
| git tag -a ${buildVersion} -m "${{ env.SOURCE_VERSION_MESSAGE }}" | ||
| git push origin --tags | ||
| - name: Bump version and push tag | ||
| uses: anothrNick/github-tag-action@v1 # Don't use @master or @v1 unless you're happy to test the latest version |
There was a problem hiding this comment.
What's up with this comment? Should we use a sha digest instead? Or a more specific version like the current @v1.71.0 (is it even possible? I never tried a full tag before)?
Should Renovate update this non-official/well-known/trusted action? Two years ago, our security department asked to pin the digest of actions. I don't know if it still applies today.
There was a problem hiding this comment.
Sorry I copy/pasted this comment from the upstream page of the github action. I will go perform these changes in a new PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes use of https://github.com/marketplace/actions/github-tag-bump.
The strategy replicates what we have on ADO: automatically increment
patchnumbers.We can instruct the workflow to increment
minorormajorversions in the merge commit message.