Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 #5

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

Python3 #5

wants to merge 36 commits into from

Conversation

maiksaray
Copy link

Python 3 support implemented.

The only thing left is to update version and reupload to PyPI

@gsnedders
Copy link
Owner

Hey!

FWIW: This hasn't really been maintained in a long time (and never really by me).

I'm happy to add support for Python 3, and this prompted me to get #3 landed (at last!), but trying to run tox -e py37 with this merged shows that some of the test files still use Py2 syntax. Could you add Python 3.7 to .travis.yml and tox.ini and fix it so it passes?

Thanks!

@maiksaray
Copy link
Author

maiksaray commented Mar 13, 2019

I'm sorry, it seems that tox.ini is not in the repo. I (or @rokatyy ) will have a look at .travis.yml and test code

@gsnedders
Copy link
Owner

There's definitely tox.ini in master; you'll need to rebase/merge onto master to get that present.

Mikhail Saravayskiy added 2 commits March 14, 2019 13:18
# Conflicts:
#	.travis.yml
#	t/image_test.py
 * fixed one more Exception usage
@maiksaray
Copy link
Author

CI failed, investigating

template/provider.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants