RfC: Support vmnet on macOS #466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables support for macOS vmnet devices. This allows to use
switchmode on current macOS devices.Current state of this PR is a bit rough but working, open todos include:
I'll happily address these shortcomings, I just wanted check beforehand if there is some interest in this feature.
MacOS seems to filter packages outside the initially configured subnet, limiting what can be done with
tinc-up. As a workaround I propose adding a couple of device specific configuration variables, namely:(mirroring what qemu accepts for network configuration, conflating start and end address).
Suggestions regarding code style/structure are most welcome.