Improve line numbers #2470
Improve line numbers #2470
Conversation
|
The line numbers is fixed to the left. Before 2024-11-07-line-numbers.mp4Now 2024-11-07-line-numbers-fixed.mp4 |
app/src/main/java/net/gsantner/markor/frontend/textview/LineNumbersTextView.java
Show resolved
Hide resolved
app/src/main/java/net/gsantner/markor/activity/DocumentEditAndViewFragment.java
Outdated
Show resolved
Hide resolved
| { | ||
| if (_lineNumbersView.isLineNumbersEnabled()) { | ||
| final long time = System.currentTimeMillis(); | ||
| if (time - _lineNumbersRefreshTime > 125) { |
There was a problem hiding this comment.
Why a time based vs a scroll based refresh like we do now?
There was a problem hiding this comment.
The time based code just reduces the refresh rate of line numbers when scrolling.
There was a problem hiding this comment.
But we already have a system where the line numbering only redraws after the user has scrolled by some delta (1 page iirc). IMO that is superior
There was a problem hiding this comment.
That system is called passively when the view is changed, it works well when the view is EditText, but now this view is TextView. So this code is designed to actively trigger that system to check and determine whether to draw new line numbers.
There was a problem hiding this comment.
How well does it work on bigger files (old and new)? Redrawing partial should work better, isn't it?
There was a problem hiding this comment.
Yes, I think it's better than before.
2025-01-03-line-numbers-33000-lines.mp4
app/src/main/java/net/gsantner/markor/frontend/textview/LineNumbersTextView.java
Outdated
Show resolved
Hide resolved
Refactor this feature: