Select lines #2443
Open
Select lines #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
harshad1
commented
Oct 14, 2024
4 tasks
gsantner
reviewed
Oct 18, 2024
| @@ -411,8 +411,7 @@ public GsFileBrowserOptions.Options getFilesystemFragmentOptions(GsFileBrowserOp | |||
| public void onFsViewerConfig(GsFileBrowserOptions.Options dopt) { | |||
| dopt.descModtimeInsteadOfParent = true; | |||
| dopt.rootFolder = _appSettings.getNotebookDirectory(); | |||
| final File fallback = _appSettings.getFolderToLoadByMenuId(_appSettings.getAppStartupFolderMenuId()); | |||
| final File file = MarkorContextUtils.getValidIntentFile(getIntent(), fallback); | |||
| final File file = MarkorContextUtils.getValidIntentFile(getIntent(), dopt.rootFolder); | |||
There was a problem hiding this comment.
Does Markor still startup with i.e. Favorites or storage if you select that in the filebrowser app settings?
|
Might I suggest a unicode symbol instead of text? I know already that translating those two words will result in what you would consider a sentence. And you want to have more then just this option listed 😄 |
harshad1
commented
Nov 7, 2024
| } | ||
| } | ||
| _lastFilter = constraint.toString().toLowerCase().trim(); | ||
| _filter(_originalList, _filteredList); |
There was a problem hiding this comment.
we don't want to run an async filter inside load folder as it is already async. So we break the internal processing out into a stand-alone function
|
Changed from text to icon
|
|
Resolved merge conflict. This is ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to select lines which pops up in the long press menu in the text editor. The menu remains open so we can easily copy or replace selections.