Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove FetchEvent, HIDInputReportEvent and TimeEvent #109

Merged
merged 1 commit into from
Sep 14, 2024
Merged

remove FetchEvent, HIDInputReportEvent and TimeEvent #109

merged 1 commit into from
Sep 14, 2024

Conversation

FredericHeem
Copy link
Member

No description provided.

@FredericHeem FredericHeem mentioned this pull request Sep 13, 2024
Closed
louwers
louwers suggested changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EventListener type is identical to (event: any) => any.

It should be replaced with that.

@FredericHeem
Copy link
Member Author

The types which has been removed from the union were any, The EventListener should be correct with this PR

@louwers
Copy link
Contributor

louwers commented Sep 13, 2024

Hmm for me it still shows as any.

But I think there is very little value in such a large union, because you need to type cast anyway to do anything useful with these types.

@FredericHeem
Copy link
Member Author

EventListener is no longer (event: any) => any.

Screenshot 2024-09-13 at 17 56 46

@FredericHeem FredericHeem merged commit 9b06ac5 into main Sep 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louwers louwers louwers requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FredericHeem @louwers