Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Migrate off legacy JS/HTML apis #730

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

minoic
Copy link

@minoic minoic commented Aug 17, 2024

The purpose of this PR is to fix the issue mentioned in #715, I have test both unary/server side stream requests on canvaskit/wasm platform.Thanks to @hyunw55 `s comment in #715 (comment).

Main updates include:

  1. add web v1.0.0 package and XMLHttpRequest to replace html package.
  2. use dart.library.io to determine the current platform.

Copy link

linux-foundation-easycla bot commented Aug 17, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@aran
Copy link
Contributor

aran commented Aug 19, 2024

@kevmoo do you happen to know who would be the right maintainers to look at this?

@kevmoo
Copy link
Contributor

kevmoo commented Aug 19, 2024

Thanks for chiming in here @aran
And thanks for the PR @minoic

I'll work to find a reviewer!

Copy link

github-actions bot commented Aug 19, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
grpc Non-Breaking 4.0.2-wip 4.0.2-wip 4.0.2-wip ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
lib/grpc_or_grpcweb.dart 💚 57 %
lib/src/client/transport/xhr_transport.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
grpc Any
$1.Duration
ServerHandler

This check can be disabled by tagging the PR with skip-leaking-check.

Package publish validation ✔️
Package Version Status
package:grpc 4.0.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

pubspec.yaml Outdated Show resolved Hide resolved
@grpc grpc deleted a comment from github-actions bot Aug 20, 2024
lib/src/client/transport/xhr_transport.dart Outdated Show resolved Hide resolved
lib/src/client/transport/xhr_transport.dart Outdated Show resolved Hide resolved
@kevmoo
Copy link
Contributor

kevmoo commented Sep 26, 2024

We published a new pkg:web with those HTTP helpers

We need to rebase this fix, too

@kevmoo
Copy link
Contributor

kevmoo commented Oct 4, 2024

looks like we need to do another merge here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants