-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: Migrate off legacy JS/HTML apis #730
base: master
Are you sure you want to change the base?
Conversation
@kevmoo do you happen to know who would be the right maintainers to look at this? |
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs.
Coverage
|
File | Coverage |
---|---|
lib/grpc_or_grpcweb.dart | 💚 57 % |
lib/src/client/transport/xhr_transport.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
.
API leaks ⚠️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package | Leaked API symbols |
---|---|
grpc | Any $1.Duration ServerHandler |
This check can be disabled by tagging the PR with skip-leaking-check
.
Package publish validation ✔️
Package | Version | Status |
---|---|---|
package:grpc | 4.0.2-wip | WIP (no publish necessary) |
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.
We published a new We need to rebase this fix, too |
looks like we need to do another merge here |
The purpose of this PR is to fix the issue mentioned in #715, I have test both unary/server side stream requests on canvaskit/wasm platform.Thanks to @hyunw55 `s comment in #715 (comment).
Main updates include:
XMLHttpRequest
to replace html package.dart.library.io
to determine the current platform.