fix eslint

growingio · Sep 6, 2024 · a71cbd3 · a71cbd3
1 parent 64d094b
commit a71cbd3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/src/past-time-picker/PastTimePicker.tsx b/src/past-time-picker/PastTimePicker.tsx
@@ -119,14 +119,14 @@ const PastTimePicker = (props: PastTimePickerProps) => {
   const humanizeTimeRange = (
     time: string,
     defaultString = timeRangeText,
-    quickOptions: PastTimePickerProps['quickOptions']
+    _quickOptions: PastTimePickerProps['quickOptions']
   ) => {
     if (!time) {
       return defaultString;
     }
 
-    let op;
-    if ((op = quickOptions?.find((option) => option.value === time))) {
+    const op = _quickOptions?.find((option) => option.value === time);
+    if (op) {
       return op.label;
     }
 

diff --git a/src/past-time-picker/demos/PastTimePicker.stories.tsx b/src/past-time-picker/demos/PastTimePicker.stories.tsx
@@ -93,9 +93,7 @@ Modes.args = {
 };
 
 export const DisabledDate = () => {
-  const disabledDate = (current: Date) => {
-    return differenceInDays(startOfToday(), current) > 7;
-  };
+  const disabledDate = (current: Date) => differenceInDays(startOfToday(), current) > 7;
 
   return (
     <PastTimePicker

diff --git a/src/static-past-time-picker/StaticPastTimePicker.tsx b/src/static-past-time-picker/StaticPastTimePicker.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { useCallback } from 'react';
 import { usePrefixCls, useLocale } from '@gio-design/utils';
 import { filter } from 'lodash';
 import SelectList from '../list';
@@ -87,7 +87,7 @@ function StaticPastTimePicker({
 
   earliestApprove && options.push({ value: 'earliest', label: earliestInHistory });
 
-  const parseMode = (current: string | undefined) => parseTimeMode(current, options);
+  const parseMode = useCallback((current: string | undefined) => parseTimeMode(current, options), [options]);
   const originMode = parseMode(timeRange) ?? 'quick';
   const [mode, setMode] = React.useState<string | undefined>(originMode);