Skip to content

Commit

Permalink
drop 2.7 too because rails cannot get installed
Browse files Browse the repository at this point in the history
  • Loading branch information
grosser committed May 20, 2024
1 parent 30228b5 commit e3cbe56
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 14 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby: [ '2.7', '3.0' ]
ruby: [ '3.0' ]
task: [ 'default' ]
gemfile: [ 'rails52' ]
include:
- ruby: '2.7' # lowest supported version
- ruby: '3.0' # lowest supported version
task: rubocop
gemfile: rails52
name: ${{ matrix.ruby }} ${{ matrix.gemfile }} rake ${{ matrix.task }}
Expand All @@ -32,7 +32,7 @@ jobs:
- uses: actions/checkout@v2
- uses: ruby/setup-ruby@v1
with:
ruby-version: 3.0
ruby-version: 3.3
bundler-cache: true
- run: gem i gettext && gem i activesupport && bundle exec rake benchmark
namespaces:
Expand All @@ -41,6 +41,6 @@ jobs:
- uses: actions/checkout@v2
- uses: ruby/setup-ruby@v1
with:
ruby-version: 3.0
ruby-version: 3.3
bundler-cache: true
- run: echo 'gem "gettext"' >> Gemfile && echo 'gem "iconv"' >> Gemfile && bundle config unset deployment && bundle && bundle exec rake namespaces
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ require:
- rubocop-packaging

AllCops:
TargetRubyVersion: 2.7 # keep in sync with minimum version
TargetRubyVersion: 3.0 # keep in sync with minimum version
Exclude:
- vendor/**/*
- gemfiles/vendor/**/*
Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ DEPENDENCIES
rubocop
rubocop-packaging
single_cov
sqlite3 (~> 1.6.9)
sqlite3

BUNDLED WITH
2.5.10
2 changes: 1 addition & 1 deletion fast_gettext.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Gem::Specification.new name, FastGettext::VERSION do |s|
s.add_runtime_dependency 'prime'

s.add_development_dependency 'rake'
s.add_development_dependency 'sqlite3', '~> 1.6.9' # last version with ruby 2.7 support
s.add_development_dependency 'sqlite3'
s.add_development_dependency 'rspec'
s.add_development_dependency 'activerecord'
s.add_development_dependency 'i18n'
Expand Down
16 changes: 9 additions & 7 deletions gemfiles/rails52.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,11 @@ GEM
marcel (1.0.1)
method_source (1.0.0)
mini_mime (1.1.1)
mini_portile2 (2.6.1)
mini_portile2 (2.8.6)
minitest (5.14.4)
nio4r (2.7.3)
nokogiri (1.12.3)
mini_portile2 (~> 2.6.1)
nokogiri (1.16.5)
mini_portile2 (~> 2.8.2)
racc (~> 1.4)
parallel (1.21.0)
parallel_tests (2.31.0)
Expand All @@ -102,8 +102,9 @@ GEM
bundler (>= 1.3.0)
railties (= 5.2.6)
sprockets-rails (>= 2.0.0)
rails-dom-testing (2.0.3)
activesupport (>= 4.2.0)
rails-dom-testing (2.2.0)
activesupport (>= 5.0.0)
minitest
nokogiri (>= 1.6)
rails-html-sanitizer (1.4.2)
loofah (~> 2.3)
Expand Down Expand Up @@ -153,7 +154,8 @@ GEM
actionpack (>= 4.0)
activesupport (>= 4.0)
sprockets (>= 3.0.0)
sqlite3 (1.3.13)
sqlite3 (2.0.1)
mini_portile2 (~> 2.8.0)
thor (1.1.0)
thread_safe (0.3.6)
tzinfo (1.2.9)
Expand Down Expand Up @@ -181,4 +183,4 @@ DEPENDENCIES
sqlite3

BUNDLED WITH
2.3.27
2.5.10

0 comments on commit e3cbe56

Please sign in to comment.