Skip to content

Commit

Permalink
pmem: disable flag verification until pmem#5979 is fixed
Browse files Browse the repository at this point in the history
Signed-off-by: Tomasz Gromadzki <[email protected]>
  • Loading branch information
grom72 committed Jan 25, 2024
1 parent 6ee3f36 commit ac4f3c9
Showing 1 changed file with 23 additions and 1 deletion.
24 changes: 23 additions & 1 deletion src/libpmem/pmem.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: BSD-3-Clause
/* Copyright 2014-2023, Intel Corporation */
/* Copyright 2014-2024, Intel Corporation */

/*
* pmem.c -- pmem entry points for libpmem
Expand Down Expand Up @@ -573,10 +573,18 @@ pmem_memmove(void *pmemdest, const void *src, size_t len, unsigned flags)
LOG(15, "pmemdest %p src %p len %zu flags 0x%x",
pmemdest, src, len, flags);

/*
* XXX
* Disable this warning until #5979 is fixed
* https://github.com/pmem/pmdk/issues/5979
*/
#if 0
#ifdef DEBUG
if (flags & ~PMEM_F_MEM_VALID_FLAGS)
ERR("invalid flags 0x%x", flags);
#endif
#endif

PMEM_API_START();
Funcs.memmove_nodrain(pmemdest, src, len, flags & ~PMEM_F_MEM_NODRAIN,
Funcs.flush, &Funcs.memmove_funcs);
Expand All @@ -597,10 +605,17 @@ pmem_memcpy(void *pmemdest, const void *src, size_t len, unsigned flags)
LOG(15, "pmemdest %p src %p len %zu flags 0x%x",
pmemdest, src, len, flags);

/*
* Disable this warning until #5979 is fixed
* https://github.com/pmem/pmdk/issues/5979
*/
#if 0
#ifdef DEBUG
if (flags & ~PMEM_F_MEM_VALID_FLAGS)
ERR("invalid flags 0x%x", flags);
#endif
#endif

PMEM_API_START();
Funcs.memmove_nodrain(pmemdest, src, len, flags & ~PMEM_F_MEM_NODRAIN,
Funcs.flush, &Funcs.memmove_funcs);
Expand All @@ -621,9 +636,16 @@ pmem_memset(void *pmemdest, int c, size_t len, unsigned flags)
LOG(15, "pmemdest %p c 0x%x len %zu flags 0x%x",
pmemdest, c, len, flags);

/*
* XXX
* Disable this warning until #5979 is fixed
* https://github.com/pmem/pmdk/issues/5979
*/
#if 0
#ifdef DEBUG
if (flags & ~PMEM_F_MEM_VALID_FLAGS)
ERR("invalid flags 0x%x", flags);
#endif
#endif

PMEM_API_START();
Expand Down

0 comments on commit ac4f3c9

Please sign in to comment.