Support VNC password authentication #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now we could proxy VNC servers only if no authentication was required by the server (RFB_AUTHTYPE_NONE). This patch adds an extra configuration option --vnc-password, the value of which will be used as the password when RFB_AUTHTYPE_VNC authentication is requested by the server. Add missing CONTRIBUTORS file and adjust Copyright messages accordingly. Signed-off-by: Dimitris Aragiorgis <[email protected]>
For security reasons, the password should not show up in the command line. We replace the '--vnc-password' option with the '--vnc-password-file' option that expects a file path as its value. This file should contain the password in plain text in the first line. The remaining lines will be ignored. Update the docs accordingly. Signed-off-by: Dimitris Aragiorgis <[email protected]>
Add support for authenticating against VNC servers that require different passwords. The VNC password file should now include one password per line, where lines starting with "#" are ignored. If the server requests for password authentication, then the proxy will try to connect using available passwords in the order found in the password file. If a server changes its password then this password should be added in the VNC password file and vncauthproxy should be restarted. This patch improves logging with regard to the VNC authentication progress. Signed-off-by: Dimitris Aragiorgis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set adds support for authenticating against VNC servers that require different passwords.
The passwords will be included in a multi-line file which will be passed to vncauthproxy via the '--vnc-password-file' option.