Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tests to JUnit5 #626

Merged
merged 9 commits into from
Oct 23, 2024
Merged

Migrate tests to JUnit5 #626

merged 9 commits into from
Oct 23, 2024

Conversation

Tristan-WorkGH
Copy link
Contributor

@Tristan-WorkGH Tristan-WorkGH self-assigned this Oct 17, 2024
TheMaskedTurtle
TheMaskedTurtle requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@TheMaskedTurtle TheMaskedTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You created new sonar issues please revert them

@Tristan-WorkGH Tristan-WorkGH force-pushed the junit/migrate5 branch 2 times, most recently from 03499c0 to 49bd090 Compare October 23, 2024 11:13
@Tristan-WorkGH
fix wrong assertion in test
2bd7da5 
an event is created in the before AND in the test, so there is 2 events on same uuid
@Tristan-WorkGH
out of scope to fix that
b96225c
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
22 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Tristan-WorkGH Tristan-WorkGH merged commit f0d4664 into main Oct 23, 2024
3 checks passed
@Tristan-WorkGH Tristan-WorkGH deleted the junit/migrate5 branch October 23, 2024 15:10
TheMaskedTurtle added a commit that referenced this pull request Oct 24, 2024
@TheMaskedTurtle
Revert "Migrate tests to JUnit5 (#626)"
57b555b 
This reverts commit f0d4664.
TheMaskedTurtle added a commit that referenced this pull request Oct 24, 2024
@TheMaskedTurtle
Revert "Migrate tests to JUnit5 (#626)" (#630)
55ca191 
This reverts commit f0d4664.
Tristan-WorkGH pushed a commit that referenced this pull request Oct 24, 2024
@TheMaskedTurtle @Tristan-WorkGH
Revert "Revert "Migrate tests to JUnit5 (#626)" (#630)"
6950433 
This reverts commit 55ca191.
@Tristan-WorkGH Tristan-WorkGH mentioned this pull request Oct 24, 2024
Merged
Tristan-WorkGH added a commit that referenced this pull request Oct 24, 2024
@Tristan-WorkGH
Redo "Migrate tests to JUnit5 (#626)" with fix (#631)
574f6fe 
* Revert "Revert "Migrate tests to JUnit5 (#626)" (#630)"
  This reverts commit 55ca191.
* revert the missing dependency in runtime scope
* revert also modifications of main code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMaskedTurtle TheMaskedTurtle TheMaskedTurtle approved these changes

Assignees

@Tristan-WorkGH Tristan-WorkGH

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tristan-WorkGH @TheMaskedTurtle