Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First timepoint implementation #612

Merged
merged 68 commits into from
Nov 5, 2024
Merged

First timepoint implementation #612

merged 68 commits into from
Nov 5, 2024

Conversation

klesaulnier
Copy link
Contributor

No description provided.

LE SAULNIER Kevin added 30 commits September 6, 2024 08:58
feat: first implementation of timepoints
854b650 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Merge remote-tracking branch 'origin/main' into timepoint-implementation
8b547f4
fix: tests
ede825a 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
temporary commit
4debb85 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
feat: keep implementing timepoints
fe39ef8 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Merge remote-tracking branch 'origin/main' into timepoint-implementation
6202846
fix: some fixes before changing structure
14d84a2 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: remove abstract timepoints links
c1a186f 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: compilable version + changelogs
ae83bf8 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: keep fixing issues
702f984 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: creating study and network-modification working
436fddc 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
feat: keep implementing timepoints
fbda22c 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
feat: more and more functionnality working
1e8bfcc 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
feat: keep fixing app
7a7a85a 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Merge remote-tracking branch 'origin/main' into timepoint-implementation
acfec1c
fix: node building
a31de48 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: other node creation
0bd65ee 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: copy/pasting node + modifications now applied on right variant
0aff56d 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: duplication / move modifications
41ceeef 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: get root reports now working
139168a 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: study deletion
6e6426a 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: clean code + checkstyle
83bb335 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: keep cleaning code
e2181f6 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: formatting
682ddef 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: study deletion
8a8a2f7 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: tests
fdc76d4 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: dynamic simulation tests
a13a4b6 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: more tests
04248b9 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: some more tests
1fd2a67 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
fix: some more tests
9d6413b 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
SlimaneAmar
SlimaneAmar reviewed Oct 23, 2024
View reviewed changes
src/main/java/org/gridsuite/study/server/repository/timepoint/TimePointEntity.java Outdated
@JoinColumn(name = "studyUuid")
private StudyEntity study;

@OneToMany(orphanRemoval = true, mappedBy = "timePoint", cascade = CascadeType.ALL)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the foreign key -> study_id_fk_constraint ?

...idsuite/study/server/networkmodificationtree/entities/NetworkModificationNodeInfoEntity.java Outdated
protected List<TimePointNodeInfoEntity> timePointNodeInfos;

//TODO temporary, for now we are only working with one timepoint by study
@Transient
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove @Transient

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

...a/org/gridsuite/study/server/networkmodificationtree/entities/NodeBuildStatusEmbeddable.java
@Embeddable
@EqualsAndHashCode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ?

src/main/java/org/gridsuite/study/server/service/NetworkModificationTreeService.java Outdated
this.rootNodeInfoRepository = rootNodeInfoRepository;
}

private NodeEntity createNetworkmodificationNode(StudyEntity study, NodeEntity parentNode, NetworkModificationNode networkModificationNode) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Slimane AMAR and others added 8 commits October 23, 2024 11:27
Merge branch 'main' of https://github.com/powsybl/powsybl-study-server …
c2e955e 
…into timepoint-implementation
Now 'rootNekwork' creations done by the RootNetworkService
31b21a9 
Signed-off-by: Slimane AMAR <[email protected]>
Merge branch 'main' of https://github.com/powsybl/powsybl-study-server …
4c35971 
…into timepoint-implementation
Merge branch 'main' of https://github.com/powsybl/powsybl-study-server …
2f57c05 
…into timepoint-implementation
@souissimai
resolve conflicts: cleaning modificationsToExclude
50165fe 
Signed-off-by: maissa SOUISSI <[email protected]>
@souissimai
resolve conflicts
7329282 
Signed-off-by: maissa SOUISSI <[email protected]>
Use spring service 'RootNetworkNodeInfoService' to duplicate a node
f89c0b2 
Signed-off-by: Slimane AMAR <[email protected]>
Use spring service 'RootNetworkNodeInfoService' to duplicate a node
b0bd18c 
Signed-off-by: Slimane AMAR <[email protected]>
@SlimaneAmar SlimaneAmar force-pushed the timepoint-implementation branch from f89c0b2 to b0bd18c Compare October 28, 2024 08:32
souissimai and others added 10 commits October 28, 2024 09:38
@souissimai
Merge branch 'timepoint-implementation' of https://github.com/gridsui…
4656d33 
…te/study-server into timepoint-implementation
@souissimai
remove patch
847644b 
Signed-off-by: maissa SOUISSI <[email protected]>
Pass 'rootNetworkUuid' as argument to 'completeNodeInfos' method
f7195d0 
Signed-off-by: Slimane AMAR <[email protected]>
Merge branch 'main' of https://github.com/powsybl/powsybl-study-server …
583203c 
…into timepoint-implementation
Add indexes and rename foreign keys
27c26b9 
Signed-off-by: Slimane AMAR <[email protected]>
fix: test was a bit buggy
270b020 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Merge branch 'timepoint-implementation' of https://github.com/gridsui…
b49cad6 
…te/study-server into timepoint-implementation
Merge branch 'timepoint-implementation' of https://github.com/powsybl…
41197c1 
…/powsybl-study-server into timepoint-implementation
fix: getAllReportUuids was returning root uuids multiple times
fb6cdab 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Merge branch 'timepoint-implementation' of https://github.com/gridsui…
d2d721b 
…te/study-server into timepoint-implementation
@souissimai souissimai self-requested a review November 4, 2024 09:52
Slimane AMAR and others added 3 commits November 4, 2024 11:23
@SlimaneAmar SlimaneAmar force-pushed the timepoint-implementation branch from 7621aed to 7245d04 Compare November 5, 2024 09:18
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed

Issues
28 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SlimaneAmar SlimaneAmar merged commit 3d3ae17 into main Nov 5, 2024
3 checks passed
@SlimaneAmar SlimaneAmar deleted the timepoint-implementation branch November 5, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@souissimai souissimai souissimai approved these changes

@SlimaneAmar SlimaneAmar SlimaneAmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klesaulnier @SlimaneAmar @souissimai