Add metrics observation #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent MILLOT <[email protected]>
Signed-off-by: Florent MILLOT <[email protected]>
Signed-off-by: Florent MILLOT <[email protected]>
Signed-off-by: Florent MILLOT <[email protected]>
Signed-off-by: Florent MILLOT <[email protected]>
Signed-off-by: Florent MILLOT <[email protected]>
Signed-off-by: Florent MILLOT <[email protected]>
SlimaneAmar
reviewed
Jan 10, 2024
.../java/org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisWorkerService.java
Outdated
Show resolved
Hide resolved
klesaulnier
approved these changes
Jan 11, 2024
sBouzols
reviewed
Jan 11, 2024
Comment on lines
44
to
45
| public <E extends Throwable> void observe(String name, SensitivityAnalysisRunContext runContext, Observation.CheckedRunnable<E> callable) throws E { | ||
| createObservation(name, runContext).observeChecked(callable); |
There was a problem hiding this comment.
Suggested change
| public <E extends Throwable> void observe(String name, SensitivityAnalysisRunContext runContext, Observation.CheckedRunnable<E> callable) throws E { | |
| createObservation(name, runContext).observeChecked(callable); | |
| public <E extends Throwable> void observe(String name, SensitivityAnalysisRunContext runContext, Observation.CheckedRunnable<E> runnable) throws E { | |
| createObservation(name, runContext).observeChecked(runnable); |
There was a problem hiding this comment.
I just copy paste from other MS https://github.com/gridsuite/security-analysis-server/blob/6bab1554756090fef76bf5ec82dd3d6600fb4fd5/src/main/java/org/gridsuite/securityanalysis/server/service/SecurityAnalysisObserver.java#L44-L46
I didn't notice, but indeed it should be changed everywhere.
There was a problem hiding this comment.
Signed-off-by: Florent MILLOT <[email protected]>
Signed-off-by: Florent MILLOT <[email protected]>
SlimaneAmar
requested changes
Jan 11, 2024
| Counter.builder(COMPUTATION_COUNTER_NAME) | ||
| .tag(PROVIDER_TAG_NAME, provider) | ||
| .tag(TYPE_TAG_NAME, COMPUTATION_TYPE) | ||
| .tag(STATUS_TAG_NAME, getStatusFromResult(result)) |
There was a problem hiding this comment.
You mean I should not use incrementCount as in security server ?
There was a problem hiding this comment.
As discussed, I always return OK
Signed-off-by: Florent MILLOT <[email protected]>
|
SlimaneAmar
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.