optimisation: group requests to filter server #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamal-khey
changed the title
jamal-khey
changed the title
AAJELLAL
requested changes
Dec 15, 2023
...org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisInputBuilderService.java
Outdated
Show resolved
Hide resolved
...org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisInputBuilderService.java
Outdated
Show resolved
Hide resolved
...org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisInputBuilderService.java
Outdated
Show resolved
Hide resolved
...org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisInputBuilderService.java
Outdated
Show resolved
Hide resolved
src/test/java/org/gridsuite/sensitivityanalysis/server/SensitivityAnalysisControllerTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/sensitivityanalysis/server/service/FilterService.java
Outdated
Show resolved
Hide resolved
...org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisInputBuilderService.java
Outdated
Show resolved
Hide resolved
...org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisInputBuilderService.java
Outdated
Show resolved
Hide resolved
...org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisInputBuilderService.java
Outdated
Show resolved
Hide resolved
...org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisInputBuilderService.java
Outdated
Show resolved
Hide resolved
...org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisInputBuilderService.java
Outdated
Show resolved
Hide resolved
...org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisInputBuilderService.java
Outdated
Show resolved
Hide resolved
...org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisInputBuilderService.java
Outdated
Show resolved
Hide resolved
...org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisInputBuilderService.java
Outdated
Show resolved
Hide resolved
src/test/java/org/gridsuite/sensitivityanalysis/server/service/FilterServiceTest.java
Show resolved
Hide resolved
AAJELLAL
reviewed
Dec 15, 2023
...org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisInputBuilderService.java
Outdated
Show resolved
Hide resolved
Comment on lines
170
to
171
| List<String> containerNamesList = filters.stream().map(EquipmentsContainer::getContainerName).toList(); | ||
| String containerNames = Arrays.toString(containerNamesList.toArray()); |
There was a problem hiding this comment.
You can refactor this part to avoid code duplication since it's commonly used with getIdentifiablesFromContainer
Proposition:
private String getContainerNames(List<EquipmentsContainer> filters) {
List<String> containerNamesList = filters.stream().map(EquipmentsContainer::getContainerName).toList();
return Arrays.toString(containerNamesList.toArray());
}
Then use it here:
.withValue("name", getContainerNames(filters))
src/test/java/org/gridsuite/sensitivityanalysis/server/service/FilterServiceTest.java
Show resolved
Hide resolved
|
I found a problem during a test and reported it but I didn't reproduce it with Jamal yet. Will check back on it monday with Jamal before any approval. |
Probleme found , i did a fix and added few tests to detect the issue |
|
Mathieu-Deharbe
approved these changes
Dec 18, 2023
AAJELLAL
approved these changes
Dec 20, 2023
jamal-khey
deleted the
jamal-khey/optimisation-group-quequests-to-filter-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.