Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle userId and shorten error messages #53

Merged
merged 2 commits into from
Dec 19, 2023
Merged

handle userId and shorten error messages #53

merged 2 commits into from
Dec 19, 2023

Conversation

Mathieu-Deharbe
Copy link
Contributor

1 Bug fix : The full error message is still logged but only a shortened version is sent through rabbitmq (prevents it from crashing).

  1. userId is added to the run context and transmitted in the messages (because it is needed in order to display the error messages on the front side)

@Mathieu-Deharbe
reformat shortenMessage
af43ab0 
Signed-off-by: Mathieu DEHARBE <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Mathieu-Deharbe Mathieu-Deharbe merged commit a9045e7 into main Dec 19, 2023
3 checks passed
@Mathieu-Deharbe Mathieu-Deharbe deleted the handle-userId-and-shorten-error-messages branch December 19, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomillot flomillot flomillot approved these changes

@achour94 achour94 achour94 approved these changes

@SlimaneAmar SlimaneAmar Awaiting requested review from SlimaneAmar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mathieu-Deharbe @achour94 @flomillot