Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update FilterIdent with containerId and containerName #33

Merged
merged 4 commits into from
Sep 29, 2023
Merged

update FilterIdent with containerId and containerName #33

merged 4 commits into from
Sep 29, 2023

Conversation

ghazwarhili
Copy link
Contributor

No description provided.

@EstherDarkish EstherDarkish changed the title update FilterIdent with filterId and filterName [WIP] update FilterIdent with filterId and filterName Sep 19, 2023
@ghazwarhili ghazwarhili changed the title [WIP] update FilterIdent with filterId and filterName update FilterIdent with containerId and containerName Sep 20, 2023
etiennehomer
etiennehomer reviewed Sep 20, 2023
View reviewed changes
src/main/java/org/gridsuite/sensitivityanalysis/server/dto/ContainerIdent.java Outdated
public class FilterIdent {
UUID id;
String name;
public class ContainerIdent {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EquipmentsContainer to be homogeneous with study-server ?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ayolab ayolab self-requested a review September 25, 2023 13:13
@ghazwarhili ghazwarhili merged commit 2d0478f into main Sep 29, 2023
4 checks passed
@ghazwarhili ghazwarhili deleted the move-custom-param-sensi-to-window-parameter branch September 29, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayolab ayolab ayolab approved these changes

@etiennehomer etiennehomer etiennehomer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghazwarhili @etiennehomer @ayolab