Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogTable : remove direct report dependency and include severity fetching logic #2480

Conversation

ayolab
Copy link
Contributor

@ayolab ayolab commented Jan 7, 2025

No description provided.

Copy link
Contributor

@TheMaskedTurtle TheMaskedTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed maybe move the severities fetching in report-viewer-tab.jsx and computation-report-viewer.tsx because we need to fetch that only once at initial loading.

Signed-off-by: Ayoub LABIDI <[email protected]>
@ayolab ayolab requested a review from TheMaskedTurtle January 7, 2025 13:35
Signed-off-by: Ayoub LABIDI <[email protected]>
Copy link

sonarqubecloud bot commented Jan 7, 2025

@ayolab ayolab merged commit e4c4711 into main Jan 7, 2025
5 checks passed
@ayolab ayolab deleted the ayolab/log-table-remove-report-dependency-and-include-severity-fetching-logic branch January 7, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants