Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable interactions with sld in drawing mode #2169

Merged
merged 15 commits into from
Jul 18, 2024
Merged

Disable interactions with sld in drawing mode #2169

merged 15 commits into from
Jul 18, 2024

Conversation

AAJELLAL
Copy link
Contributor

No description provided.

jamal-khey

This comment was marked as outdated.

Sign in to view

jamal-khey
jamal-khey reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@jamal-khey jamal-khey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can still open SLD using search, may be see with the PO if we disable sld opening via search ?

src/components/map-viewer.jsx Outdated Show resolved Hide resolved
souissimai
souissimai approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@souissimai souissimai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe should check if need also to avoid search when drawing mode is enabled, but not really included in this US

@souissimai souissimai self-requested a review July 17, 2024 10:51
@AAJELLAL
Some renaming.
5374a88 
Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
Copy link
Contributor Author

maybe should check if need also to avoid search when drawing mode is enabled, but not really included in this US

I mentioned the point during the daily, the search can be used to zoom in on a piece of equipment.

@AAJELLAL
Copy link
Contributor Author

we can still open SLD using search, may be see with the PO if we disable sld opening via search ?

I mentioned the point during the daily, the search can be used to zoom in on a piece of equipment and it's not really an interaction with the map.

@AAJELLAL AAJELLAL requested a review from jamal-khey July 17, 2024 14:08
souissimai
souissimai approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@souissimai souissimai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, code OK

@AAJELLAL AAJELLAL requested a review from souissimai July 18, 2024 14:02
jamal-khey
jamal-khey approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@jamal-khey jamal-khey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test OK
Code Ok

@AAJELLAL AAJELLAL merged commit 03c9ed6 into main Jul 18, 2024
3 checks passed
@AAJELLAL AAJELLAL deleted the disable-sld-display-if-edit-mode-activated branch July 18, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@souissimai souissimai souissimai approved these changes

@jamal-khey jamal-khey jamal-khey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AAJELLAL @jamal-khey @souissimai