[Rework] split ParameterLine #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capyq
force-pushed
the
rework/ParameterLine
branch
from
c64a25d to
8b22eda
Compare
|
rename file to parameter-group instead of Parameter-group ? |
capyq
force-pushed
the
rework/ParameterLine
branch
2 times, most recently
from
2eb9a86 to
ed0d0fd
Compare
done |
jonenst
approved these changes
Jul 19, 2024
Tristan-WorkGH
requested changes
Jul 19, 2024
added 5 commits
July 19, 2024 13:00
…nt from common ui in equipement selection parameters Signed-off-by: capyq <[email protected]>
Signed-off-by: capyq <[email protected]>
Signed-off-by: capyq <[email protected]>
Signed-off-by: capyq <[email protected]>
Signed-off-by: capyq <[email protected]>
capyq
force-pushed
the
rework/ParameterLine
branch
from
13c34a3 to
53ce46b
Compare
Tristan-WorkGH
approved these changes
Jul 19, 2024
sBouzols
reviewed
Jul 19, 2024
| @@ -5,46 +5,37 @@ | |||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. | |||
| */ | |||
|
|
|||
| import { ElementType } from '@gridsuite/commons-ui'; | |||
| import { ElementType, EquipmentType } from '@gridsuite/commons-ui'; | |||
There was a problem hiding this comment.
Ok but it's not exactly the same enum, there is no TIE_LINE in the commons-ui enum.
Signed-off-by: capyq <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.