Migrate criteria filters to expert filters #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basseche
changed the title
basseche
force-pushed
the
migration-equipment-filter
branch
from
66b3f16 to
03e5f84
Compare
Signed-off-by: Thang PHAM <[email protected]>
… migration-equipment-filter
src/main/java/org/gridsuite/filter/server/migrations/MigrateEquipmentFilter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/filter/server/migrations/MigrateEquipmentFilter.java
Outdated
Show resolved
Hide resolved
basseche
force-pushed
the
migration-equipment-filter
branch
from
793b434 to
594fd42
Compare
basseche
force-pushed
the
migration-equipment-filter
branch
from
594fd42 to
8807198
Compare
etiennehomer
changed the title
etiennehomer
previously approved these changes
Nov 29, 2024
etiennehomer
requested changes
Nov 29, 2024
| } | ||
|
|
||
| @Test | ||
| public void testExportFilters() throws Exception { |
There was a problem hiding this comment.
You should keep the parts that test identifier list filters
| UUID filterId3 = UUID.fromString("42b70a4d-e0c4-413a-8e3e-78e9027d300c"); | ||
| UUID filterId4 = UUID.fromString("42b70a4d-e0c4-413a-8e3e-78e9027d300d"); | ||
|
|
||
| LineFilter lineFilter = LineFilter.builder().equipmentID("NHV1_NHV2_1").substationName1("P1").substationName2("P2") |
There was a problem hiding this comment.
should be replaced by some other filter type
| UUID filterId2 = UUID.randomUUID(); | ||
| UUID filterId3 = UUID.randomUUID(); | ||
|
|
||
| LineFilter lineFilter1 = LineFilter.builder().equipmentID("NHV1_NHV2_1").substationName1("P1").substationName2("P2") |
There was a problem hiding this comment.
should be replaced by some other filter type
| @@ -2148,120 +1409,4 @@ public void testExpertFilterLoadLinkToOtherFilterWithIsPartOfOperator() throws E | |||
| checkFilterEvaluating(expertFilter, expectedResultJson); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testLineFiltersCrudInBatch() throws Exception { | |||
There was a problem hiding this comment.
@thangqp this test should be kept also nope ?
There was a problem hiding this comment.
but there are only criteria Filters inside
There was a problem hiding this comment.
In my opinion, every ancient tests for general features, but using criteria-based filters, should be replaced by equivalent expert filters
etiennehomer
requested changes
Dec 2, 2024
| @@ -220,565 +219,6 @@ public String joinWithComma(Object... array) { | |||
| return join(array, ","); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Remove all ununsed methods
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
…dsuite/filter-server into delete_code_criteria_filters
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
|
etiennehomer
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migration all criteria based filters to expert filters, code clean will be done in the next PR