Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gateway panel in pods supervision #468

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YenguiSeddik
Copy link
Contributor

No description provided.

@antoinebhs
Copy link
Contributor

For this to work, I had to add the gateway IP in prometheus.yaml, I think we should add it?

{
"datasource": {
"type": "prometheus",
"uid": "PBFA97CFB590B2093"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uid should be

      "uid": "${datasource}"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll get that if you export the dashboard for external use in the share option

@@ -1126,13 +1126,213 @@
],
"type": "table"
},
{
Copy link
Contributor

@antoinebhs antoinebhs Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure these gateway metrics fits in "pods supervision"? In my opinion, it should be in a separate dashboard.
@SlimaneAmar do you agree?

@antoinebhs
Copy link
Contributor

I'm not sure what's the actual difference between active vs connections, can you detail this part?
If I understand the metrics we're monitoring the number of synchronous processing (this does not include for example asynchronous processing with queues), is it correct?

@@ -1126,13 +1126,213 @@
],
"type": "table"
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with @SlimaneAmar , these metrics should be added to the table "Pods info and restarts".
total connections => current threads
active connections => busy threads

Copy link
Contributor

@antoinebhs antoinebhs Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be no timeseries for now, it will be done in a separate dashboard/PR

Signed-off-by: Seddik Yengui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants