Feature/gsye 810 #1818
Open
Feature/gsye 810 #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rts of the heat pumps because they are not needed
…to only have one source of truth
hannesdiedrich
commented
Nov 29, 2024
| @@ -28,59 +28,59 @@ def setup_method(self): | |||
| self._datetime = datetime(2023, 1, 1, 0, 0) | |||
|
|
|||
| def test_increase_tanks_temp_from_heat_energy(self): | |||
| self._tanks.increase_tanks_temp_from_heat_energy(1, self._datetime) | |||
| self._tanks.increase_tanks_temp_from_heat_energy(5000, self._datetime) | |||
There was a problem hiding this comment.
@spyrostz You need 4186 J to heat up one liter of water by 1 degree. Hence, in our cases where we talk about hundrets of liters we should change to use kJ as unit for the heat demand profile in order to not have too large numbers, for the input as well as for the output. What do you think?
If you agree, I will add a ticket for this.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1818 +/- ##
==========================================
+ Coverage 69.55% 69.65% +0.10%
==========================================
Files 148 150 +2
Lines 14181 14245 +64
Branches 2656 2666 +10
==========================================
+ Hits 9863 9922 +59
- Misses 3793 3794 +1
- Partials 525 529 +4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for the proposed changes
Please describe what we want to achieve and why.
Proposed changes
INTEGRATION_TESTS_BRANCH=master
GSY_FRAMEWORK_BRANCH=feature/GSYE-810