Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staked value fix #212

Merged
merged 10 commits into from
Oct 2, 2024
Merged

staked value fix #212

merged 10 commits into from
Oct 2, 2024

Conversation

apporc
Copy link
Contributor

@apporc apporc commented Sep 19, 2024

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Sep 19, 2024

Deploying unicove with  Cloudflare Pages  Cloudflare Pages

Latest commit: 71ddbd9
Status: ✅  Deploy successful!
Preview URL: https://6cf22ec2.wallet-2tl.pages.dev
Branch Preview URL: https://apporc-fix.wallet-2tl.pages.dev

View logs

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for unicove ready!

Name Link
🔨 Latest commit 1b08ac6
🔍 Latest deploy log https://app.netlify.com/sites/unicove/deploys/66ebf6c8b6238d0008829808
😎 Deploy Preview https://deploy-preview-212--unicove.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for unicove ready!

Name Link
🔨 Latest commit 71ddbd9
🔍 Latest deploy log https://app.netlify.com/sites/unicove/deploys/66fd7d9e2cb6e6000895dd0b
😎 Deploy Preview https://deploy-preview-212--unicove.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/pages/earn/index.svelte Outdated Show resolved Hide resolved
src/pages/earn/index.svelte Outdated Show resolved Hide resolved
src/pages/earn/index.svelte Outdated Show resolved Hide resolved
src/pages/earn/index.svelte Outdated Show resolved Hide resolved
Copy link
Contributor

@dafuga dafuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left you some suggestions, but I think it's fine to merge this as is as we don't want to spend too much time on this codebase.

@dafuga
Copy link
Contributor

dafuga commented Sep 21, 2024

This is what is causing the CI checks to fail:

/home/runner/work/unicove/unicove/src/pages/earn/step/bootstrap.svelte:10:5
Error: This import is never used as a value and must use 'import type' because 'importsNotUsedAsValues' is set to 'error'. (ts)
    import InputLabel from '~/components/elements/input/label.svelte'
    import {REXInfo} from '../types'

@apporc
Copy link
Contributor Author

apporc commented Sep 23, 2024

This is what is causing the CI checks to fail:

/home/runner/work/unicove/unicove/src/pages/earn/step/bootstrap.svelte:10:5
Error: This import is never used as a value and must use 'import type' because 'importsNotUsedAsValues' is set to 'error'. (ts)
    import InputLabel from '~/components/elements/input/label.svelte'
    import {REXInfo} from '../types'

Fixed, thanks.
about the ! problems, i think we can leave it as is, as you said.

@aaroncox aaroncox merged commit 721d8a8 into dev Oct 2, 2024
6 checks passed
aaroncox added a commit that referenced this pull request Oct 2, 2024
* earn: add rexfund into staked value

* Update src/pages/earn/index.svelte

Co-authored-by: Daniel Fugere <[email protected]>

* Update src/pages/earn/index.svelte

Co-authored-by: Daniel Fugere <[email protected]>

* Update src/pages/earn/index.svelte

Co-authored-by: Daniel Fugere <[email protected]>

* Update src/pages/earn/index.svelte

Co-authored-by: Daniel Fugere <[email protected]>

* Update src/pages/earn/index.svelte

Co-authored-by: Daniel Fugere <[email protected]>

* Syntax fixes

* browser list updates

* Revert "browser list updates"

This reverts commit c5ac2d1.

---------

Co-authored-by: Aaron Cox <[email protected]>
Co-authored-by: Daniel Fugere <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants