Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Overlay Calendar v2 and Troubleshooter v2 #41

Closed
wants to merge 12 commits into from
Closed

feat: Overlay Calendar v2 and Troubleshooter v2 #41

wants to merge 12 commits into from

Conversation

lizard-boy
Copy link

What does this PR do?

  • This PR currently only fetches event titles for Google and Office365 Calendar.
  • This PR allows users to use Overlay Calendar feature by signing in using their Google Account.
  • It also pulls actual event title from the calendar instead of just showing "Busy" for both overlay calendar and troubleshooter.
  • This feature upgrade does not need any Google scope changes.
  • As per the comment here feat: Overlay Calendar v2 and Troubleshooter v2 calcom/cal.com#14575 (review), I am sticking with the existing Google OAuth Provider. But since we're using it for both regular and overlay user sign-ups, telling them apart during registration is tricky. So, I couldn't automate Google Calendar setup for overlay users after sign-up. Instead, I'm redirecting them to "/getting-started/connect-calendar" to connect it manually. Let me know if you have any other ideas.

Fixes calcom#12763
Fixes calcom#12752

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

Testing Overlay Calendar v2

  • Just go to a booking page and toggle the Overlay Calendar switch.
  • Choose Continue with Google and sign in with a google id.
  • You will be taken to "/getting-started/connect-calendar" page.
  • Connect your google calendar.
  • You will then be redirected to the booking page.
  • You will see that now event titles are being displayed instead of just "Busy" for the calendar busy events.

Testing Troubleshooter v2

  • Just go to the Troubleshooter and make sure that google calendar is connected and the app is checking google calendar for conflicts.
  • You will see that now event titles are being displayed instead of just "Busy" for the calendar busy events.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

sean-brydon and others added 12 commits September 17, 2024 19:09
@sean-brydon
feat: update vitest version v0.34 to V2.11 (calcom#16676)
e7415fe 
* update version

* fix button to match new spec

* migrate tests to objectContaining

* fix tests

* update RTL

* yarn.lock update

* bump fetch mock to latest vitest version

* update deep mock to use vitest 2.0

* fix mock prisma type cast

* meet base test fn singature for V2

* remove console.log from next test
@keithwillcode
chore: v4.5.1 (calcom#16690)
a53e697
@CarinaWolli
fix: dates in ooo booking redirect email (calcom#16692)
5067f0d
@calcom-bot @replexicabot
feat: update translations (calcom#16693)
5ad7360 
Co-authored-by: Replexica <[email protected]>
@zomars
fix: new user detection for dub analytics (calcom#16695)
3a5325f
@ThyMinimalDev @SomayChauhan
chore: EventTypeWebWrapper base pr (calcom#16550)
2b43d9a 
* chore: EventTypeWebWrapper base pr

* fixup! chore: EventTypeWebWrapper base pr

* fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base

* wip

* fix: error

* Event type atom wrapper handles app dir

* fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base

* fixup! fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base

* remove console log

* review comments

* fixup! review comments

* fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base

---------

Co-authored-by: Somay Chauhan <[email protected]>
@supalarry
refactor: v2 and atoms booking fields (calcom#16685)
5b5a42e 
* refactor: define inputs and outputs by separating default and custom fields

* refactor: event type api <-> internal transformers

* refactor: v2 use refactored libraries to transform input and output booking fields

* refactor: dont allow custom slugs with default reserved slugs

* refactor: input service store only specific default system fields

* refactor: atoms display only specific default system fields

* refactor: delete unused system field constants

* fix: tests

* fix: old event types

* fix: imports

* fix: import

* chore: release libraries and use v2 with them

* fix: unit tests

* refactor: push email in case of missing phone

* refactor: satisfies check for event-type locations
@anikdhabal
fix: fixed more flaky e2e tests (round 2) (calcom#16660)
021e5f3 
* fix: fixed more flaky e2e tests (round 2)

* update

* fix and update

* update
@sean-brydon
fix(eslint): Adds eslint-ignore-patterns to eslint config (calcom#16701)
1058c0e
@PeerRich
feat: Retell AI (calcom#16706)
a9ebb0d 
* added retell ai to app store

* added retell ai
@SomayChauhan @ThyMinimalDev
refactor: event setup tab web wrapper (calcom#16672)
abb4fd3 
* chore: EventTypeWebWrapper base pr

* fixup! chore: EventTypeWebWrapper base pr

* fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base

* wip

* fix: error

* Event type atom wrapper handles app dir

* fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base

* fixup! fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base

* remove console log

* refactor: event-type-atom (setup tab)

* review comments

* update: better naming

* fixup! review comments

* revert: defaultMenuIsOpen --will create a separate PR

---------

Co-authored-by: Morgan Vernay <[email protected]>
Co-authored-by: Morgan <[email protected]>
@zomars
feat: per user and team feature flags (calcom#16040)
a2b064b
@lizard-boy lizard-boy closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
❗️ migrations
Projects
None yet
Milestone
No milestone