forked from calcom/cal.com
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add advanced tab attributes to api/v2/event-types #28
Closed
lizard-boy
wants to merge
23
commits into
main
from
feat/api-v2-extend-event-types-advanced-tab-16314
Closed
feat: add advanced tab attributes to api/v2/event-types #28
lizard-boy
wants to merge
23
commits into
main
from
feat/api-v2-extend-event-types-advanced-tab-16314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update version * fix button to match new spec * migrate tests to objectContaining * fix tests * update RTL * yarn.lock update * bump fetch mock to latest vitest version * update deep mock to use vitest 2.0 * fix mock prisma type cast * meet base test fn singature for V2 * remove console.log from next test
Co-authored-by: Replexica <[email protected]>
* chore: EventTypeWebWrapper base pr * fixup! chore: EventTypeWebWrapper base pr * fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base * wip * fix: error * Event type atom wrapper handles app dir * fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base * fixup! fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base * remove console log * review comments * fixup! review comments * fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base --------- Co-authored-by: Somay Chauhan <[email protected]>
* refactor: define inputs and outputs by separating default and custom fields * refactor: event type api <-> internal transformers * refactor: v2 use refactored libraries to transform input and output booking fields * refactor: dont allow custom slugs with default reserved slugs * refactor: input service store only specific default system fields * refactor: atoms display only specific default system fields * refactor: delete unused system field constants * fix: tests * fix: old event types * fix: imports * fix: import * chore: release libraries and use v2 with them * fix: unit tests * refactor: push email in case of missing phone * refactor: satisfies check for event-type locations
* fix: fixed more flaky e2e tests (round 2) * update * fix and update * update
* added retell ai to app store * added retell ai
* chore: EventTypeWebWrapper base pr * fixup! chore: EventTypeWebWrapper base pr * fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base * wip * fix: error * Event type atom wrapper handles app dir * fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base * fixup! fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base * remove console log * refactor: event-type-atom (setup tab) * review comments * update: better naming * fixup! review comments * revert: defaultMenuIsOpen --will create a separate PR --------- Co-authored-by: Morgan Vernay <[email protected]> Co-authored-by: Morgan <[email protected]>
…erSideProps`/`getStaticProps` to `/lib` (calcom#16458) * booking: Move getServerSideProps to /lib * remove duplicate * bookings: Move getStaticProps to /lib * fix type check * replace setHeader with a server action call in withEmbedSSR * Add env variables for booking
* chore: removes unnecessary prisma env warnings * Revert lockfile Signed-off-by: zomars <[email protected]> * Update yarn lock Signed-off-by: zomars <[email protected]> --------- Signed-off-by: zomars <[email protected]>
* docs: schedules * docs: wip event-types * docs:event-types * docs:event-types * Delete yarn.lock * Revert "Delete yarn.lock" This reverts commit bb3eb23. --------- Co-authored-by: Morgan <[email protected]>
calcom#16648) * fix settings/admin/page * remove references to pages for settings/teams * remove double layouts * move pages that do not need layout out of (settings) group * fix * fix * fix * fix * add sso page and fix layouts
Co-authored-by: Peer Richelsen <[email protected]>
… in `/auth`, `/insights`, `/d`, `signup` and add missing default `/future` page (calcom#16589) * remove references to /pages for sso, setup, signin pages in /auth * remove references to pages for insights * remove references to pages for d * remove references to pages for signup * add page for /future index page * fix routing-forms * fix * add missing defaults * use getServerSessionForAppDir instead * fix apps/[slug]/[...pages] * fix metadata in apps/slug/pages * refactor * refactor * remove duplicate code for PageProps * remove references to pages for /reschedule * fix * fix routing forms * type fix * fix routing forms again * revert changes for app/slug/pages * revert * revert changes in yarn lock --------- Co-authored-by: Joe Au-Yeung <[email protected]>
Co-authored-by: Replexica <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces the
advancedTab
attribute to the following updated endpoints:Event Types:
/v2/event-types
/v2/event-types/{eventTypeId}
/v2/event-types/{eventTypeId}
— now includes additional attributes.Organizations Event Types:
/v2/organizations/{orgId}/teams/{teamId}/event-types
/v2/organizations/{orgId}/teams/{teamId}/event-types/{eventTypeId}
/v2/organizations/{orgId}/teams/{teamId}/event-types/{eventTypeId}
— now includes additional attributes.Adds a disabled state to the following attributes:
seats
recurrence
bookingLimitsCount
bookingLimitsDuration
bookingWindow
confirmationPolicy
Commits related to this change:
Refactors the codebase to implement pipes for transforming input data and uses interceptors for transforming output data. The goal is to keep the service layer cleaner by handling transformation logic at the controller level, allowing services to interact freely without duplicating transformation processes.
Commits related to this change:
Refactors our event-type input, output, and update classes to extend from a single base class. This simplifies the process of adding new attributes in the future.
Commit related to this change:
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
"version": "1.2.3"
inpackages/platform/libraries/package.json
."@calcom/platform-libraries-1.2.3": "npm:@calcom/[email protected]"
toapps/api/v2/package.json
.Cannot write file
error while runningapi/v2
, delete thedist
folder inplatform/types
and try runningapi/v2
again.Testing
api/v2/event-types
:1. Layout:
2. Requires Confirmation - Always:
3. Requires Confirmation - When booked with less than:
4. Requires Confirmation - Disabled:
5. Requires Booker Email Verification:
6. Hide Notes in Calendar:
7. Offer Seats:
8. Offer Seats — Disabled:
9. Lock Timezone on Booking Page:
10. Event Type Color:
11. Custom Event Name:
Input for the handler:
API V2:
Valid Variables that can be used in the custom event name:
{Event type title}
{Organiser}
{Scheduler}
{Location}
{Organiser first name}
{Scheduler first name}
{Scheduler last name}
{Event duration}
{LOCATION}
{HOST/ATTENDEE}
{HOST}
{ATTENDEE}
{USER}
12. Destination Calendar:
Input for the handler:
API V2:
Note on Testing:
Testing this feature requires a connected calendar. Here's how you can test it:
destinationCalendars
connected to the account.externalId
andintegration
from the response and use them in the create-event type payload as shown above.13. Use Event Type Destination Calendar Email:
Input for the handler:
API V2:
Note on Enabling:
To enable this, a calendar must already be connected to your account.